Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68778
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8pnaj1s_tsYDZz5G3G6uD2J0CNdRh1yhB_TWSNhZgxdw@mail.gmail.com>
References: <CAF+90c_i7bU0CGPiA4pgL+d+C+Py1279DTYRivQnSorhc9oq7Q@mail.gmail.com>
	<CAF+90c8pnaj1s_tsYDZz5G3G6uD2J0CNdRh1yhB_TWSNhZgxdw@mail.gmail.com>
Date: Sat, 31 Aug 2013 15:13:00 +0200
Message-ID: <CAF+90c818TJO1Z1hq8AUz2AbxLJbHhovHR0S8jkP1LjCu+W3kA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0111bcfa3301af04e53e194e
Subject: Re: Always set return_value_ptr?
From: nikita.ppv@gmail.com (Nikita Popov)

--089e0111bcfa3301af04e53e194e
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Aug 27, 2013 at 11:40 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Sat, Aug 3, 2013 at 8:16 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
>> Hi internals!
>>
>> Is there any particular reason why we only pass return_value_ptr to
>> internal functions if they have the ACC_RETURN_REFERENCE flag set?
>>
>> Why can't we always provide the retval ptr, even for functions that don't
>> return by reference? This would allow returning zvals without having to
>> copy them first (what RETVAL_ZVAL does).
>>
>> Motivation for this is the following SO question:
>> http://stackoverflow.com/q/17844379/385378
>>
>
> Patch for this change can be found here:
> https://github.com/php/php-src/pull/420
>
> The patch also adds new macros to allow easy use of this feature called
> RETVAL_ZVAL_FAST/RETURN_ZVAL_FAST (anyone got a better name?)
>
> If no one objects I'll merge this sometime soon.
>

Changes merged. Small benchmark to verify that this indeed avoids the copy:
https://gist.github.com/nikic/6398090 :)

Nikita

--089e0111bcfa3301af04e53e194e--