Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68744
Return-Path: <ircmaxell@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 69676 invoked from network); 30 Aug 2013 17:36:25 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Aug 2013 17:36:25 -0000
Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.169 as permitted sender)
X-PHP-List-Original-Sender: ircmaxell@gmail.com
X-Host-Fingerprint: 209.85.128.169 mail-ve0-f169.google.com  
Received: from [209.85.128.169] ([209.85.128.169:60050] helo=mail-ve0-f169.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 2F/E7-32511-918D0225 for <internals@lists.php.net>; Fri, 30 Aug 2013 13:36:25 -0400
Received: by mail-ve0-f169.google.com with SMTP id db10so1631017veb.28
        for <internals@lists.php.net>; Fri, 30 Aug 2013 10:36:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=pamU8icCgTleh2YeLRUc4Qd7GXDGCDiqk6k+8tVNJT0=;
        b=wjzZjH9sE1llzbAiyf+kPQtnEFkOJVE/4fcPhedBu6AuIMRc9UMa9E0mK3GajcXc3B
         qY5aW5ZKyQOn5BynTrRucmd+IxcHqoFQNbjhu/xXDEHFPpHJGLs0vqzLmxrumg8P2rrF
         /Fk6nQttIFoorNKiQZqkpfR2uQxXVsw5dOJ9FqFD0FspBXCKHUPHSiy8PTm7Uq6Rt6Mm
         Of+IBoV2FQj90X83lOHJLxjOYCZxEWTEckar/UdrdNxejA07j67ql93PE++Js3u43bE8
         otJr9VGJAlhDc9qp4Jozso97DkUWEPtgu0dUpcXCDTgA+NO3wpQJr+FkIBosfJsafZQF
         S9LQ==
MIME-Version: 1.0
X-Received: by 10.58.196.132 with SMTP id im4mr1539330vec.28.1377884182926;
 Fri, 30 Aug 2013 10:36:22 -0700 (PDT)
Received: by 10.58.94.201 with HTTP; Fri, 30 Aug 2013 10:36:22 -0700 (PDT)
In-Reply-To: <5220D40A.1080102@sugarcrm.com>
References: <CAAyV7nFRfuu0dGnu0FV1ehkqwQR6=dUFSHMP=6CJsAVWghCADg@mail.gmail.com>
	<5220262A.6040702@sugarcrm.com>
	<CAAyV7nHg1OBh6tZCEcGq1EGWAT_io0yhvcxCpRBLH+kv8zFn2g@mail.gmail.com>
	<5220D40A.1080102@sugarcrm.com>
Date: Fri, 30 Aug 2013 13:36:22 -0400
Message-ID: <CAAyV7nFehNCABAznVnoLsxbDm30ZbSiCZeDebJ-1hmxb4swgNg@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b6d8cc843e21704e52da9de
Subject: Re: [PHP-DEV] [DRAFT] [RFC] Function autoloading
From: ircmaxell@gmail.com (Anthony Ferrara)

--047d7b6d8cc843e21704e52da9de
Content-Type: text/plain; charset=ISO-8859-1

Stas,

I see a number of places where hash lookup is replaced with
> zend_lookup_function, not with the macro. Moreover, zend_lookup_function
> for some reason copies and lowercases the argument, even though for hash
> lookup it should already be lowercased.


There was quite literally one place I forgot to switch to the macro
expansion (in zend_API.c, zend_is_callable_check_func). I'm sorry. That has
been rectified.

As far as it being already lowercased, based on the original implementation
before refactor, I couldn't hold that as true. So I had implemented it very
similar to lookup_class.

However, after the refactor (the current state of the patch), it is
redundant. I have pushed a commit to refactor that away.

Thanks

Anthony

--047d7b6d8cc843e21704e52da9de--