Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68725
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
To: X Ryl <boite.pour.spam@gmail.com>
Cc: internals@lists.php.net
In-Reply-To: <CAHwPpv786QfVtoCwzf-_P7UNNjHykt4LwoqU3HxL1MTqUfFHcg@mail.gmail.com>
References:
	 <CAHwPpv786QfVtoCwzf-_P7UNNjHykt4LwoqU3HxL1MTqUfFHcg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 30 Aug 2013 16:52:35 +0200
Message-ID: <1377874355.2929.148.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] LFS support for PHP 5.5.1
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Fri, 2013-08-30 at 16:43 +0200, X Ryl wrote:
> Hi,
> 
> 
>   Please find attached a patch for adding large file size support to
> PHP 5.5.1.

The patch didn't make it. Please send as text/plain (i.e. using .txt
extension)

> It does so by, from the PHP's side, getting double instead of int for
> the file size/ offset functions, when the size is larger than 2^31.

This has some problems - for further handling onemight need the exact
file size (i.e. content length headers, checking structures, reading
specific positions)

> This means that files with size:
> - up to 2^32 bytes works as previously (integer returned / used)
> - up to 2^52 bytes can be handled correctly (double's mantissa is 52
> bits, no loss in precision here)

This might work for the initial operation, but as soon as the user does
a calculation ("give me the last ten bytes") this will cause issues.

> - from 2^52 up to 2^64 will have their size rounded, yet, reading and
> writing will work as expected since it's done in the PHP's binary.
> 
> 
> The changes are: 
> - Some size_t are changed to off_t wherever required.

This disqualifies from 5.5 and allows use in 5.6 only.

johannes