Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68724
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.172 as permitted sender)
MIME-Version: 1.0
Date: Fri, 30 Aug 2013 16:43:14 +0200
Message-ID: <CAHwPpv786QfVtoCwzf-_P7UNNjHykt4LwoqU3HxL1MTqUfFHcg@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/mixed; boundary=001a11c262ce0f151704e52b3ea4
Subject: [PATCH] LFS support for PHP 5.5.1
From: boite.pour.spam@gmail.com (X Ryl)

--001a11c262ce0f151704e52b3ea4
Content-Type: multipart/alternative; boundary=001a11c262ce0f151104e52b3ea2

--001a11c262ce0f151104e52b3ea2
Content-Type: text/plain; charset=ISO-8859-1

Hi,

  Please find attached a patch for adding large file size support to PHP
5.5.1.
Basically, it allows 32 bits machine to address file larger than 4GB, get
correct results when asking for their size, allows to read and write them,
etc...

It does so by, from the PHP's side, getting double instead of int for the
file size/ offset functions, when the size is larger than 2^31.

This means that files with size:
- up to 2^32 bytes works as previously (integer returned / used)
- up to 2^52 bytes can be handled correctly (double's mantissa is 52 bits,
no loss in precision here)
- from 2^52 up to 2^64 will have their size rounded, yet, reading and
writing will work as expected since it's done in the PHP's binary.

The changes are:
- Some size_t are changed to off_t wherever required.
- The code with unique mmap now loops the mmap until the complete
file/stream is done processing
- Fix for the mmap of a popen's pipe that can't work (unrelated, but easy
to fix while working on the mmap code)
- Change the return type based on the actual range of the manipulated
number (so if the value fit in a integer, a integer is used, and the code
that used to work still works, but if it does not fit, a double is used,
and the code that used to fails now works)

Please notice that I'm not a PHP developer, I don't have any time left for
maintaining this patch, but I'm sure this patch has a value. So, I deny any
right on it and put it in public domain for whoever wants to improve it,
integrate it.


Let me know your remarks.
Cyril

--001a11c262ce0f151104e52b3ea2
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>=A0 Please find attached a patch fo=
r adding large file size support to PHP 5.5.1.</div><div>Basically, it allo=
ws 32 bits machine to address file larger than 4GB, get correct results whe=
n asking for their size, allows to read and write them, etc...</div>
<div><br></div><div>It does so by, from the PHP&#39;s side, getting double =
instead of int for the file size/ offset functions, when the size is larger=
 than 2^31.</div><div><br></div><div>This means that files with size:</div>
<div>- up to 2^32 bytes works as previously (integer returned / used)</div>=
<div>- up to 2^52 bytes can be handled correctly (double&#39;s mantissa is =
52 bits, no loss in precision here)</div><div>- from 2^52 up to 2^64 will h=
ave their size rounded, yet, reading and writing will work as expected sinc=
e it&#39;s done in the PHP&#39;s binary.</div>
<div><br></div><div>The changes are:=A0</div><div>- Some size_t are changed=
 to off_t wherever required.</div><div>- The code with unique mmap now loop=
s the mmap until the complete file/stream is done processing</div><div>- Fi=
x for the mmap of a popen&#39;s pipe that can&#39;t work (unrelated, but ea=
sy to fix while working on the mmap code)</div>
<div>- Change the return type based on the actual range of the manipulated =
number (so if the value fit in a integer, a integer is used, and the code t=
hat used to work still works, but if it does not fit, a double is used, and=
 the code that used to fails now works)</div>
<div><br></div><div>Please notice that I&#39;m not a PHP developer, I don&#=
39;t have any time left for maintaining this patch, but I&#39;m sure this p=
atch has a value. So, I deny any right on it and put it in public domain fo=
r whoever wants to improve it, integrate it.=A0</div>
<div><br></div><div><br></div><div>Let me know your remarks.</div><div>Cyri=
l</div></div>

--001a11c262ce0f151104e52b3ea2--
--001a11c262ce0f151704e52b3ea4--