Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68689
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8ZF_MCBxz5168t_m6n7j4MPOZr8T8SY1P-=qc9eVZXLw@mail.gmail.com>
References: <CAMUwpuQvz3X9HHK6c=ZWujDJig4YqaQMHs4peQUky=AjCPM3cA@mail.gmail.com>
	<CAF+90c8ZF_MCBxz5168t_m6n7j4MPOZr8T8SY1P-=qc9eVZXLw@mail.gmail.com>
Date: Thu, 29 Aug 2013 09:59:32 -0600
Message-ID: <CAFMT4Np4ecB_-FjXhdw9jCAJbmRa7H_XvRAemD+kc+2zM71Y7Q@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b33d5a013ac8b04e5183147
Subject: Re: [PHP-DEV] Refactored magic methods
From: morrison.levi@gmail.com (Levi Morrison)

--047d7b33d5a013ac8b04e5183147
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Aug 29, 2013 at 5:00 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Fri, Aug 2, 2013 at 6:47 PM, Julien Pauli <jpauli@php.net> wrote:
>
> > Hi internals.
> >
> > I started a work of refactoring magic methods from internals.
> >
> > The first goal was to never write ourselves things like "__get", but use
> > macros for those names. (get, set, invoke, etc...).
> >
> > A second goal was to rewrite some parts of the compiler which looked like
> > code duplication which could benefit from macro refactoring.
> >
> > I did that.
> > All tests pass.
> >
> > It may look uglier for people who dont like having more macros, but
> anyway,
> > we can cherry pick some commits, etc...
> >
> > If you have ideas or things to say, I'm listening.
> > https://github.com/jpauli/php-src/compare/macroing
> >
>
> I'm not really a fan of heavy macro usage, so here an alternative
> suggestion:
>
>
>
> https://github.com/nikic/php-src/commit/375bd7911fd117696b8b5d63c104fd588d69c409
>
> Basically, instead of going through all the magic methods manually we
> define a structure holding information on magic methods and then loop
> through it doing generic checks.
>
> The above example only changes zend_check_magic_method_implementation, but
> the idea can be generalized to the other occurances of magic method checks
> (making the structure a global constant so they can all make use of the
> information in there.)
>
> Nikita
>

I think I like Nikita's version better. Fewer macros are nicer in my
opinion.

--047d7b33d5a013ac8b04e5183147--