Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68679
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.54 as permitted sender)
MIME-Version: 1.0
Sender: patrick.allaert@gmail.com
In-Reply-To: <CAF+90c_P6AVw1fB7BWeQSHdhLDNcWDnehZ2j7Hk6dzznZfKF=w@mail.gmail.com>
References: <CAF+90c_P6AVw1fB7BWeQSHdhLDNcWDnehZ2j7Hk6dzznZfKF=w@mail.gmail.com>
Date: Thu, 29 Aug 2013 13:14:11 +0200
Message-ID: <CACwt+Jdrq3=vSbmmrW650554VfUUxZ8PNT7VWaNArcOtC4OVLg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Signature compatibility: Number of arguments
From: patrickallaert@php.net (Patrick ALLAERT)

2013/8/29 Nikita Popov <nikita.ppv@gmail.com>:
> Hi internals!
>
> This is a spinoff from the variadics thread. Quoting Stas:
>
>> I also think this:
>>     public function query($query, ...$params)
>>     public function query(...$params)
>> should be legal too.

I respectfully disagree.

The first method requires at least one parameter (or two, depending on
the pending clarification in the other thread) , and the latest: zero
or more (or 1 or more).

> This is a general issue in PHP that we might want to fix: Currently a
> method A is not compatible with a method B if A has less arguments than B.
>
> E.g. both of the following are incompatible signatures:
>
>     public function foo($bar)
>     public function foo()
>
>     public function foo($bar = NULL)
>     public function foo()
>
> This doesn't really make sense. Removing parameters doesn't violate LSP,
> because in PHP it is legal to pass more arguments than declared. (Only
> adding additional required parameters would violate LSP.)
>
> Is it okay to change this?

I see no reason to do so and I would say -0.5.