Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68640
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8oxd4j4sj6AL+TdYu6_AoroWk1=RPdKrE7PNBs2XZg=A@mail.gmail.com>
References: <CAF+90c8oxd4j4sj6AL+TdYu6_AoroWk1=RPdKrE7PNBs2XZg=A@mail.gmail.com>
Date: Wed, 28 Aug 2013 18:18:14 +0200
Message-ID: <CAMyk_AY14DeADb1XDjNe3iSJwvqV6fLuLueMFJjJ08GHvb+nNg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2e352682f9404e504577e
Subject: Re: [PHP-DEV] [RFC] Syntax for variadic functions
From: linepogl@gmail.com (Lazare Inepologlou)

--001a11c2e352682f9404e504577e
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2013/8/28 Nikita Popov <nikita.ppv@gmail.com>

> Hi internals!
>
> I'd like to propose an RFC, which adds dedicated syntax for variadic
> functions:
>
>     https://wiki.php.net/rfc/variadics
>
> Basically this allows declaring variadics directly in the function
> signature, rather than fetching the arguments using func_get_args().
> Example:
>
>     public function query($query, ...$params) { /* ... */ }
>
> What are your thoughts on this?
>
>
+1, primarily because it makes the code self-documented.

However, I would like to hilight one shortcoming of variadic functions
(both with the old and with the proposed syntax): There is no way to call a
variadic function unless all the arguments are hard-coded.

I am extenting the example of the RFC:

class MySQL implements DB {
  public function query($query, ...$params) {
    // ...
  }
  public function query_and_log($query, ...$params) {
    // this will not work:
    $result =3D $this->query( $query, $params );
    log( $query );
    return $result;
  }
}

Not only this does not work, but there is no way to make it work without
modifying the original function. Would it be possible to extend the RFC
with new syntax that could cover cases like that as well? Maybe something
like that:

$result =3D $this->query( $query, ...$params );


Other than that, the RFC is very welcome.

Lazare INEPOLOGLOU
Ing=C3=A9nieur Logiciel






> Thanks,
> Nikita
>

--001a11c2e352682f9404e504577e--