Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68625 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 63198 invoked from network); 27 Aug 2013 12:08:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Aug 2013 12:08:31 -0000 Authentication-Results: pb1.pair.com header.from=mike.php.net@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=mike.php.net@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender) X-PHP-List-Original-Sender: mike.php.net@gmail.com X-Host-Fingerprint: 209.85.217.173 mail-lb0-f173.google.com Received: from [209.85.217.173] ([209.85.217.173:34347] helo=mail-lb0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A4/00-62705-DB69C125 for ; Tue, 27 Aug 2013 08:08:30 -0400 Received: by mail-lb0-f173.google.com with SMTP id r11so2457265lbi.18 for ; Tue, 27 Aug 2013 05:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=EAQQhWTlDA/UUPHJEaHEs2v+1xYLJ1yOGQfl5+BT+7c=; b=GXtqXWNpRg9MMgEfA3J+1IM/fVmdZMxMmPrLutatut2qxCZPRmo3XFrdmnym5ovTkx 5IK18BDXFljEV6LIivKCZWzc3t6rm4T/f0kSfoVzVZ4Xh22JZUAcoOMZrAmWMa2Vo8Xk piFpJrvqD+RMdwYXlH9eo5VKtPi+jt5fOkpA7EW6fY2FZfJ0WHbi/OKwHlCCsDDLtqyA fPb5hMe4KPPJAE6KoROzIR23Gnyww49vEbvV2k2cdvyJs6fP2IK0dkGceQCY7j0SIXYB /GfFn4McxxoJN284CpwdJyfXpi3kXawAWV9qiYYvgGKA1V42Ks1ivgeKgJJyzbqlagNS zCTQ== MIME-Version: 1.0 X-Received: by 10.152.44.225 with SMTP id h1mr18740711lam.15.1377605306522; Tue, 27 Aug 2013 05:08:26 -0700 (PDT) Sender: mike.php.net@gmail.com Received: by 10.114.184.19 with HTTP; Tue, 27 Aug 2013 05:08:26 -0700 (PDT) Date: Tue, 27 Aug 2013 14:08:26 +0200 X-Google-Sender-Auth: b71QLoCR0k4RvJTx-ifDIvJi5i4 Message-ID: To: PHP Internals Content-Type: multipart/mixed; boundary=089e0160b7beefa4b304e4ecba6d Subject: PROPOSAL: temp stream for post_data From: mike@php.net (Michael Wallner) --089e0160b7beefa4b304e4ecba6d Content-Type: text/plain; charset=UTF-8 Hi, I prepared a patch to replace sapi_globals' request_info post_data and raw_post_data with a temp stream and remove support for HTTP_RAW_POST_DATA. [1] PROS: * save up to 300% on post_data_len memory (on non-form POSTs) * a local siege (c=512/512, 2.4k form/2.2k json) showed no (negative) performance impact; see attached logs * reusable php://input stream * ... CONS: * no more $HTTP_RAW_POST_DATA, where BC could easily provided with a one-liner: $GLOBALS["HTTP_RAW_POST_DATA"]=file_get_contents("php://input"); * memory is cheap * ??? [1] https://github.com/m6w6/php-src/compare/slim-postdata-merge -- Regards, Mike --089e0160b7beefa4b304e4ecba6d Content-Type: application/json; name="logs.json" Content-Disposition: attachment; filename="logs.json" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hkuzglfk1 ICAgICAgRGF0ZSAmIFRpbWUsICBUcmFucywgIEVsYXAgVGltZSwgIERhdGEgVHJhbnMsICBSZXNw IFRpbWUsICBUcmFucyBSYXRlLCAgVGhyb3VnaHB1dCwgIENvbmN1cnJlbnQsICAgIE9LQVksICAg RmFpbGVkCioqKiogbWFpbi5qc29uICoqKioKMjAxMy0wOC0yNyAxMTo1NjoxOCwgIDUxMDMwLCAg ICAgICA5LjMzLCAgICAgICAgICAgMCwgICAgICAgMC4wOCwgICAgIDU0NjkuNDUsICAgICAgICAw LjAwLCAgICAgIDQ1OC40OCwgICA1MTAzMCwgICAgICAgMAoqKioqIG1haW4uanNvbiAqKioqCjIw MTMtMDgtMjcgMTE6NTY6NDEsICA1NTAxOCwgICAgICAgOS4wOCwgICAgICAgICAgIDAsICAgICAg IDAuMDcsICAgICA2MDU5LjI1LCAgICAgICAgMC4wMCwgICAgICA0NDkuMzQsICAgNTUwMTgsICAg ICAgIDAKKioqKiBtYWluLmpzb24gKioqKgoyMDEzLTA4LTI3IDExOjU3OjExLCAgNTcwNDgsICAg ICAgIDkuNjUsICAgICAgICAgICAwLCAgICAgICAwLjA4LCAgICAgNTkxMS43MSwgICAgICAgIDAu MDAsICAgICAgNDU1LjIwLCAgIDU3MDQ4LCAgICAgICAwCioqKiogc2xpbS5qc29uICoqKioKMjAx My0wOC0yNyAxMTo1Nzo0NSwgIDU4Njg2LCAgICAgIDEwLjAxLCAgICAgICAgICAgMCwgICAgICAg MC4wOCwgICAgIDU4NjIuNzQsICAgICAgICAwLjAwLCAgICAgIDQ1NC4yNSwgICA1ODY4NiwgICAg ICAgMAoqKioqIHNsaW0uanNvbiAqKioqCjIwMTMtMDgtMjcgMTE6NTg6MDIsICA1OTk5OCwgICAg ICAgOS44MiwgICAgICAgICAgIDAsICAgICAgIDAuMDgsICAgICA2MTA5Ljc4LCAgICAgICAgMC4w MCwgICAgICA0ODAuNDUsICAgNTk5OTksICAgICAgIDAKKioqKiBzbGltLmpzb24gKioqKgoyMDEz LTA4LTI3IDExOjU4OjE1LCAgNTk0NDIsICAgICAgIDkuODUsICAgICAgICAgICAwLCAgICAgICAw LjA4LCAgICAgNjAzNC43MiwgICAgICAgIDAuMDAsICAgICAgNDgwLjU2LCAgIDU5NDQyLCAgICAg ICAwCg== --089e0160b7beefa4b304e4ecba6d--