Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68624
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_i7bU0CGPiA4pgL+d+C+Py1279DTYRivQnSorhc9oq7Q@mail.gmail.com>
References: <CAF+90c_i7bU0CGPiA4pgL+d+C+Py1279DTYRivQnSorhc9oq7Q@mail.gmail.com>
Date: Tue, 27 Aug 2013 11:40:35 +0200
Message-ID: <CAF+90c8pnaj1s_tsYDZz5G3G6uD2J0CNdRh1yhB_TWSNhZgxdw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8ff1cefe2d154704e4eaaaf2
Subject: Re: Always set return_value_ptr?
From: nikita.ppv@gmail.com (Nikita Popov)

--e89a8ff1cefe2d154704e4eaaaf2
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Aug 3, 2013 at 8:16 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> Is there any particular reason why we only pass return_value_ptr to
> internal functions if they have the ACC_RETURN_REFERENCE flag set?
>
> Why can't we always provide the retval ptr, even for functions that don't
> return by reference? This would allow returning zvals without having to
> copy them first (what RETVAL_ZVAL does).
>
> Motivation for this is the following SO question:
> http://stackoverflow.com/q/17844379/385378
>

Patch for this change can be found here:
https://github.com/php/php-src/pull/420

The patch also adds new macros to allow easy use of this feature called
RETVAL_ZVAL_FAST/RETURN_ZVAL_FAST (anyone got a better name?)

If no one objects I'll merge this sometime soon.

Nikita

--e89a8ff1cefe2d154704e4eaaaf2--