Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68589
Return-Path: <laruence@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 51901 invoked from network); 21 Aug 2013 05:51:36 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Aug 2013 05:51:36 -0000
Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.171 as permitted sender)
X-PHP-List-Original-Sender: laruence@gmail.com
X-Host-Fingerprint: 209.85.217.171 mail-lb0-f171.google.com  
Received: from [209.85.217.171] ([209.85.217.171:49850] helo=mail-lb0-f171.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A6/34-11927-36554125 for <internals@lists.php.net>; Wed, 21 Aug 2013 01:51:32 -0400
Received: by mail-lb0-f171.google.com with SMTP id t13so245970lbd.2
        for <internals@lists.php.net>; Tue, 20 Aug 2013 22:51:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=Y5fh59jQRzUJLYCeDjBYzfsvtZMQt0EL2kyP2TtUTYw=;
        b=MpdGuvf8O16kgWBFaJ0R4muTwlApK1eWI/fVt+yBcx1n0QX8IMYPyizEi6eOdTByi1
         o2M69xAzCx+zTYAr3UksmY4TeaWvc2QT9Y88SLg3l7T09sMkO1tzzMdnMqHEhozQzrsK
         lSvfGbHRQgw4AeZ959X75tlm1JNME8Bi9L81fhpXMxhBb2bPo/LA7EPaPXE3koOh2FVP
         6xJXVMGkhFOFpEpTwH9IxMgeavuI9qcq++d4krMCXTpm03oUufoIlR93lrcJt6lZ6iE5
         GaOR82oPJ3vZtv+92z+0UZLlIkWyoyJkFu9571EHtCJh3NOnaouAJmukSuJLioOP1y9Z
         3U0Q==
X-Received: by 10.112.29.147 with SMTP id k19mr5814112lbh.9.1377064288717;
 Tue, 20 Aug 2013 22:51:28 -0700 (PDT)
MIME-Version: 1.0
Sender: laruence@gmail.com
Received: by 10.114.13.165 with HTTP; Tue, 20 Aug 2013 22:51:08 -0700 (PDT)
In-Reply-To: <CAEp07h9hAwB1WqEnWM=r+s0Kq5EZif2YBzDphTyzYWi+Uz8hNQ@mail.gmail.com>
References: <CAEp07h9hAwB1WqEnWM=r+s0Kq5EZif2YBzDphTyzYWi+Uz8hNQ@mail.gmail.com>
Date: Wed, 21 Aug 2013 13:51:08 +0800
X-Google-Sender-Auth: kYLVO_EYfIj8EX_q6JMo4-5hX74
Message-ID: <CABBJUpdZ1XJ6t9JnHoaAh4fHtQRH8ek7kxSFrhvxVV_TC5oPLg@mail.gmail.com>
To: Martin Keckeis <martin.keckeis1@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] 5.4 RecursiveDirectoryIterator
From: laruence@php.net (Laruence)

Hey:

On Tue, Aug 20, 2013 at 9:08 PM, Martin Keckeis
<martin.keckeis1@gmail.com> wrote:
> Hello together,
>
> an incompatible change was made to the 5.4 series without any notice.
>
> It's related to RecursiveDirectoryIterator
> https://bugs.php.net/bug.php?id=64228
>
> See the source here:
> https://github.com/php/php-src/blob/PHP-5.4/ext/spl/spl_directory.c#L1452
>
>
> I've never used the "SKIP_DOTS" parameter and so within the 5.4 series it
> may work or not...
>
> Drupal also had such an issue: https://drupal.org/node/1785216
>
> Two things could be done IMO:
> - revert this change from 5.4
> - mention it in the Upgrade Guide 5.3 -> 5.4
that was a bug, that if you didn't pass SKIP_DOTS , dots should no be skipped.

and this bug is also fixed in 5.3 branch.

thanks
>
> Best regards
> Martin Keckeis



-- 
Laruence  Xinchen Hui
http://www.laruence.com/