Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68521
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.44 as permitted sender)
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
In-Reply-To: <24.05.06453.4370A025@pb1.pair.com>
References: <24.05.06453.4370A025@pb1.pair.com>
Date: Thu, 15 Aug 2013 18:49:43 +0800
Message-ID: <CAHMUw2EO+nfQ44h2EZ2Oirh6=xtJkwo6R_7LL-y7vBZCL+xWgw@mail.gmail.com>
To: Matthieu Napoli <matthieu@mnapoli.fr>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=14dae9d70fa25b91a704e3fa3b92
Subject: Re: [PHP-DEV] array_unique() and object comparison
From: datibbaw@php.net (Tjerk Anne Meesters)

--14dae9d70fa25b91a704e3fa3b92
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Aug 13, 2013 at 6:15 PM, Matthieu Napoli <matthieu@mnapoli.fr>wrote:

> array_unique() is perfect for removing duplicates in a string array, but
> not so great for an array of objects.
>
> SORT_REGULAR was added to compare items without casting them to string.
> However it uses the "==" comparison operator.
>

Unless you have inserted those objects in the array using an identity map,
comparisons with == would be the most useful imho.


>
> I see two improvements:
>
> - on a short term, improve the documentation to make it explicit that the
> "==" operator will be used (the example with "(string) $elem1 === (string)
> $elem2" is misleading, "===" should be replaced with "==")
>

In fact, this is the behaviour if SORT_STRING is given, so perhaps moving
that note to where the flags are described makes sense.


>
> - on a long term, maybe add another option SORT_STRICT (like the $strict
> parameter for in_array): that sort would use the strict comparison operator
> "==="
>

+1 for that. In fact, I wouldn't mind having the option to use a custom
comparison function (though this function gets called for both the sorting
and pruning process).

:)


> Any thoughts about that?
>
> Matthieu
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
--
Tjerk

--14dae9d70fa25b91a704e3fa3b92--