Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68432
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain seld.be designates 74.125.83.45 as permitted sender)
Message-ID: <52037411.7070406@seld.be>
Date: Thu, 08 Aug 2013 12:33:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: internals@lists.php.net
References: <CE27EF9C.9917%seanc@fb.com> <CAPwsocFTxhuoLazpWC8Pt-r7H7vb=7a3G3=L19npQ6GD4CafqA@mail.gmail.com>
In-Reply-To: <CAPwsocFTxhuoLazpWC8Pt-r7H7vb=7a3G3=L19npQ6GD4CafqA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC: constructor argument promotion
From: j.boggiano@seld.be (Jordi Boggiano)

On 08.08.2013 10:34, Leigh wrote:
> I'm not sure what problem this is really trying to solve, the boilerplate
> code you mention is very explicit and it is very clear to the reader what
> is being done. Each property documented with its type, purpose and
> visibility in a common place for easy reference (at the top of the class).
> Each property that takes a value from the constructor assigned in the
> constructor. Very clear.

I for one am pretty tired of writing this boilerplate in every second
class I write. Using dependency injection you end up having to write a
LOT of those usually, and constructors typically only contain assignments.

Adding a property means: declaring the property, adding the ctor arg,
adding the assignment in the ctor. You have to write the property name 4
times. With this RFC in it'd come down to writing it once, and would
avoid having undeclared properties because someone forgot.

I am very supportive the idea, although I see that it could be confusing
to some. Maybe the syntax needs to change, but the overall change is
much welcome.

Cheers

-- 
Jordi Boggiano
@seldaek - http://nelm.io/jordi