Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68426 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72034 invoked from network); 8 Aug 2013 04:45:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2013 04:45:43 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.52 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.52 mail-la0-f52.google.com Received: from [209.85.215.52] ([209.85.215.52:39168] helo=mail-la0-f52.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EF/AC-06453-67223025 for ; Thu, 08 Aug 2013 00:45:43 -0400 Received: by mail-la0-f52.google.com with SMTP id fq13so1797995lab.39 for ; Wed, 07 Aug 2013 21:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=dOYocegsO9cW7W+wwqc7fL2AcuD6dF2b8TuBeHVAdRI=; b=Tk1fTmxgJT3uzanevOgdtut3N+xezU8guuMwvpkCYBYlUzorqgWgsB0rm+Oyxy+YVI M+QajN5KBfkU8j5Bcs3vnp6Lu2bdY1YN5XNHUGDslBu0iym2iutujX1b5mTab5LnVMSb eyLgS80WSqrndiR8O26jFE17TW0BULNNTlAuJuwdmJbAtkCgnAVyws2ecqkSy6q2Xdn8 aNyD9FPlr+/NSvjtgkfR9Y2IdSv1mlDx+Bpq3Fn+Vnx+hmL812zZaCyixmBcvXWDdD0f s3GkDEN5fJljkWFG4M2zSkDI4+jFlD4/4vGRWxDRIpaVm8V2ac676deOEzuyEQkOufbH ZdCQ== X-Received: by 10.112.35.66 with SMTP id f2mr1509469lbj.89.1375937139435; Wed, 07 Aug 2013 21:45:39 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.127.233 with HTTP; Wed, 7 Aug 2013 21:44:59 -0700 (PDT) In-Reply-To: References: <5202AE51.3010005@sugarcrm.com> Date: Thu, 8 Aug 2013 13:44:59 +0900 X-Google-Sender-Auth: nOahCZ414RfGqneLyhUUDORT7Yo Message-ID: To: Hannes Magnusson Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=14dae93d96fc6def6004e368549b Subject: Re: [PHP-DEV] crypt() should raise error without 2nd parameter From: yohgaki@ohgaki.net (Yasuo Ohgaki) --14dae93d96fc6def6004e368549b Content-Type: text/plain; charset=UTF-8 Hi Hannes, On Thu, Aug 8, 2013 at 1:22 PM, Hannes Magnusson wrote: > On Wed, Aug 7, 2013 at 6:20 PM, Yasuo Ohgaki wrote: > > Hi all, > > > > It seems there are 2 options for master branch when crypt()'s 2nd > parameter > > is omitted. > > > > - raise E_DEPRECIATED that advice use of stronger salt or > password_hash() > > and make 2nd parameter required for future release. > > - make crypt() use stronger default salt/hash w/o error > > > > Since password_hash() is supposed to do better job, first option seems > > better to me. > > > Deprecating it means it will be removed in the future. > > Please leave the function alone. This should be solved with education, > not a gun to peoples head. This would be third option. I agree that good documentation is always good. E_NOTICE might be better as E_DEPRECIATED means obsolete. I'll write RFC for voting later. Please comment so that your comments are in RFC. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --14dae93d96fc6def6004e368549b--