Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68422
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CE27EF9C.9917%seanc@fb.com>
References: <CE27EF9C.9917%seanc@fb.com>
Date: Wed, 7 Aug 2013 21:20:07 -0700
Message-ID: <CADNQb0X5e2pcxE0v+wGsKy2SaULqgMA0ecDX5pZdDFzj52sT+g@mail.gmail.com>
To: Sean Cannella <seanc@fb.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] RFC: constructor argument promotion
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Wed, Aug 7, 2013 at 12:47 PM, Sean Cannella <seanc@fb.com> wrote:
> Everyone -
>
> Hi! Since this is my first post to this list, I'll introduce myself:
> I'm an engineer who has been working on HipHop VM in New York for the last half year or so after a long time working at Microsoft on business software and services in multiple hemispheres.
>
> I wanted to get the PHP community's opinion on this feature. See the draft RFC and referenced implementation below:
>
> https://wiki.php.net/rfc/constructor-promotion


Using private and protected there seems really weird.
From globals scope, I am allowed to set private and protected
properties - but just once?


I would assume __construct(protected $bar) would only allow a child
class to set that property.. which implies the ctor itself is
protected.


Also, this seems like a very bad idea. You are encouraging "don't
bother validating your data" ideas.

-Hannes