Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68415 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46505 invoked from network); 8 Aug 2013 01:42:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2013 01:42:27 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.178 mail-lb0-f178.google.com Received: from [209.85.217.178] ([209.85.217.178:34352] helo=mail-lb0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EA/77-06453-287F2025 for ; Wed, 07 Aug 2013 21:42:27 -0400 Received: by mail-lb0-f178.google.com with SMTP id z5so2015875lbh.9 for ; Wed, 07 Aug 2013 18:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=kvMiOR9nZwxgNSN2y8O8niMECoIdE/CqryZg8fR4YoQ=; b=xBNO1MtKaR1ppyy9FKNjvlYMGR4sPXUUHu+6+ROkUdJMHbxpfSi+StS5SOjTaB96Mr vAqF/RuJzJy/OMJlVeaJKIOEZvr7V8jMIIdXpWfopxbufBB7JYnDeaH7oAYsaPpTudHL tLs4hn/ELAbbCpNqVuKPaqkz+gsjm751NLKA3991A6CHOo/q1b/s4R2C/JQgYMMSO3Ez Iu2XYtVAofdsuI7eC0vo/5hGZW+T5oEM5aENvOnVIx1FV29C0J+OVmwqjsqmAzOsF1mB a7HuXhKZI19zZUmGNW6UTwq7m6XskLD9PN/i76PFAy0nCz5o6P0m4wxFnEdhwaUZY95M 5Mnw== X-Received: by 10.112.29.17 with SMTP id f17mr1321512lbh.45.1375926143520; Wed, 07 Aug 2013 18:42:23 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.127.233 with HTTP; Wed, 7 Aug 2013 18:41:43 -0700 (PDT) In-Reply-To: <5202EE67.5020307@sugarcrm.com> References: <5202AF52.9060200@sugarcrm.com> <5202EE67.5020307@sugarcrm.com> Date: Thu, 8 Aug 2013 10:41:43 +0900 X-Google-Sender-Auth: Id4iigSm878FCGRtx4uReZbovVg Message-ID: To: Stas Malyshev Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a1133c6900597f504e365c5e6 Subject: Re: [PHP-DEV] "php_serialize" session serialize handler From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a1133c6900597f504e365c5e6 Content-Type: text/plain; charset=UTF-8 Hi Stas On Thu, Aug 8, 2013 at 10:03 AM, Stas Malyshev wrote: > > Personally, I would not use numeric index. > > However, users are expecting it to work and there is no way to raise > > I don't think it is reasonable to expect it to work, it never worked, it > never was documented to work and there's no real use case for it. I also think this limitation was documented, but it seems it gone (or I missed) > The limitation is come from register_globals and it has nasty problem. > > I don't see how is it a nasty problem if there's actually no good reason > to do this. If there is a good reason to do it, please tell what it is. PHP Notice: Unknown: Skipping numeric key 1 in Unknown on line 0 https://bugs.php.net/bug.php?id=65359 This error occurs at shutdown. Removing unneeded limitation is good reason IMHO. If there is $_SESSION[$key] = $var; It's very hard to find what is and where is wrong. > > Most users don't care what serializer does and users who may have > > BC issue can use old serializers anytime. > > Using old serializer is work which we would make users do for > improvement that practically nobody needs and that does not provide any > actual improvement that can not easily be achieved otherwise. Breaking > BC just because somebody somewhere needs an exotic feature that can > easily be worked around doesn't look like a good idea to me. I should have mentioned that new serializer not only allow numeric index, but also allow special characters due to the implementation. i.e. ! and | may be used with the new serializer. Removing unneeded limitations, rather than forcing them to users, is user friendly and the way to go. IMHO. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a1133c6900597f504e365c5e6--