Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68402
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.115 as permitted sender)
Message-ID: <5202AA42.7070006@sugarcrm.com>
Date: Wed, 07 Aug 2013 13:12:50 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: Sean Cannella <seanc@fb.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <CE27EF9C.9917%seanc@fb.com>
In-Reply-To: <CE27EF9C.9917%seanc@fb.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC: constructor argument promotion
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> https://wiki.php.net/rfc/constructor-promotion

1. From the first glance, it doesn't seem clear how this syntax would
interact with magic methods - i.e., if you have __get, would access to
$make call it? If not, it's rather un-intuitive since the property is
not defined in the class but magic method is not called.

2. What would happen with this code:

class Base { public __construct(public $f) {} }
class PublicBase extends Base {
  public __construct($param) { __parent::__construct($param); }
}

class Child extends PublicBase { public __construct(public $f) {
$this->f = 42; parent::__construct($f); } }

Note here that whoever writes class Child may not be aware that class
Base even exists and how it is implemented, since he implements against
PublicBase.

3. What happens if I need to have some arguments that are not properties?

4. How would one extract phpdoc descriptions for such properties?
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227