Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68370
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 60121 invoked from network); 5 Aug 2013 01:02:16 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Aug 2013 01:02:16 -0000
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.49 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.215.49 mail-la0-f49.google.com  
Received: from [209.85.215.49] ([209.85.215.49:47027] helo=mail-la0-f49.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 29/B8-06453-699FEF15 for <internals@lists.php.net>; Sun, 04 Aug 2013 21:02:15 -0400
Received: by mail-la0-f49.google.com with SMTP id ev20so1603829lab.8
        for <internals@lists.php.net>; Sun, 04 Aug 2013 18:02:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type;
        bh=kwWkTMGUSQqm1bznSQ52mNMDZ7+Ysyq3Ztm2jfJMnD0=;
        b=p+x0sEIHL0cCRWBIM5feFQRVYC5fk3sjssbM0NlssE06A5q+xXkVfVdLR0HMpt31Uw
         wgcR8Zk5v6nXmrx+O15tQKfQfOA395GFaLavo5Xn4NCNyFGz/AvqJ/8a5YbJ6u8Hdj0e
         TSgGQ0L/0vLT3P20r3Eo94CRWWhjtmIAvetvPRt9jZ7D5NGNCA0wIHcE/TJ9lLVvVVF6
         2axh+gmewZVZunJCLQWP8HCCb0bwKlew5y0PHTIV1k58AsdRfMcK/p0FDNgee4BeUT5v
         xE+qgUGolt0YE6HthVd9EwyMnehEAWEo6UtmMjhTZLUEZXD+98rK17sLGon9GzzWQiqC
         fKEw==
X-Received: by 10.112.155.169 with SMTP id vx9mr7801282lbb.89.1375664531886;
 Sun, 04 Aug 2013 18:02:11 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.112.133.201 with HTTP; Sun, 4 Aug 2013 18:01:31 -0700 (PDT)
In-Reply-To: <51FEF5AA.5060409@sugarcrm.com>
References: <CAJRMtAGcN-n9wv8-CFiLt+bXhMvOcmfG8a3kBORVUVCz9n4Bqw@mail.gmail.com>
 <50364644.1060302@lerdorf.com> <CAJRMtAH=-B8+M6+kMrpKQZ=Yg2ASa5iv=JCUbjvHkw0UFmw73w@mail.gmail.com>
 <CAL+t6cHj4p=RLwSRGX789w-CswZQd_XtuL364KRBsc66ROdmJA@mail.gmail.com>
 <CAGa2bXY2+kDx32evFmFqUD3P1L6x=PypnVJTuj_mP2853QWQKw@mail.gmail.com>
 <5039D249.30707@sugarcrm.com> <CAGa2bXZso_S3fOUogqMwiTYJKtK3KZH5Fs8GZApxMnT+DwgpbQ@mail.gmail.com>
 <CAGa2bXauBFja+BJcLxiE5t5rnfna1QDt3iTRdYr04a1ExFz7+A@mail.gmail.com>
 <503A968A.4070206@sugarcrm.com> <CAGa2bXaMYxD3-mbATK0WfEryVEvjHE8m2RnujTauLN8t1S+H6w@mail.gmail.com>
 <CAGa2bXZ3pYiO5Lfn5NS-vuPBk_X6SUsr6Qsswya6mx0S3SjgeQ@mail.gmail.com>
 <CAGa2bXY-+B-_-3N2=VYy7rJB-eXF0nzrGA-eSJmM+O87qDrx-Q@mail.gmail.com>
 <51FEEEAF.1070705@sugarcrm.com> <51FEF5AA.5060409@sugarcrm.com>
Date: Mon, 5 Aug 2013 10:01:31 +0900
X-Google-Sender-Auth: veLmKwBUiYGtBNS3gNoJOQtaEpc
Message-ID: <CAGa2bXY0f+vveuRi5hbtfk2d2jn80zAwg0611nqEHXuzNJXBWA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e01182586c0d82a04e328dbcb
Subject: Re: [PHP-DEV] Session Id Collisions
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--089e01182586c0d82a04e328dbcb
Content-Type: text/plain; charset=UTF-8

Hi Stas,

On Mon, Aug 5, 2013 at 9:45 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> >> https://github.com/php/php-src/pull/368
> >> https://github.com/php/php-src/pull/367
> >> https://github.com/php/php-src/pull/366
>
> I've amended your patch slightly:
> https://github.com/php/php-src/pull/401
>
> and it looks fine to me now. What do you think, is it OK with you?


Thank you for noticing crash. Data can be null, so the fix is OK.
Removing the limitation that prohibits setting session ID is fine for me,
too.

Please, apply your patch.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--089e01182586c0d82a04e328dbcb--