Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68365
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.73.107 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CAF+90c_i7bU0CGPiA4pgL+d+C+Py1279DTYRivQnSorhc9oq7Q@mail.gmail.com>
References:
	 <CAF+90c_i7bU0CGPiA4pgL+d+C+Py1279DTYRivQnSorhc9oq7Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Sun, 04 Aug 2013 00:56:39 +0200
Message-ID: <1375570599.9187.58.camel@ghost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Always set return_value_ptr?
From: ab@php.net (Anatol Belski)

Hi Nikita,

On Sat, 2013-08-03 at 20:16 +0200, Nikita Popov wrote: 
> Why can't we always provide the retval ptr, even for functions that don't
> return by reference? This would allow returning zvals without having to
> copy them first (what RETVAL_ZVAL does).

were it not possible to zval_add_ref() the item one needs to return?
Possibly recursive. I can rebember doing similar to 

array_init(return_value);

for(zend_hash_internal_pointer_reset(Z_ARRVAL_P(my_array));
        zend_hash_has_more_elements(Z_ARRVAL_P(my_array)) == SUCCESS;
        zend_hash_move_forward(Z_ARRVAL_P(my_array)))
    {

    zval **my_array_item;

    if(zend_hash_get_current_data(Z_ARRVAL_P(my_array),
(void**)&my_array_item) == FAILURE) {
        continue;
    }

    zend_hash_get_current_key(Z_ARRVAL_P(my_array), &string_key,
&num_key, 0)
    zval_add_ref(my_array_item);
    zend_hash_update(Z_ARRVAL_P(return_value), string_key,
strlen(string_key), my_array_item, sizeof(zval *), NULL);
}

That's still some overhead, but even in case my_array_item was non
scalar, that should be working. Unfortunately i've no access to that
code anymore. my_array were of course a flat array, for a complex array
it should be done recursive.

Regards

anatol