Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68362
Return-Path: <morrison.levi@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 56999 invoked from network); 2 Aug 2013 19:55:08 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Aug 2013 19:55:08 -0000
Authentication-Results: pb1.pair.com header.from=morrison.levi@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=morrison.levi@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.172 as permitted sender)
X-PHP-List-Original-Sender: morrison.levi@gmail.com
X-Host-Fingerprint: 209.85.214.172 mail-ob0-f172.google.com  
Received: from [209.85.214.172] ([209.85.214.172:38352] helo=mail-ob0-f172.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 54/0C-24726-A9E0CF15 for <internals@lists.php.net>; Fri, 02 Aug 2013 15:55:07 -0400
Received: by mail-ob0-f172.google.com with SMTP id er7so1961427obc.31
        for <internals@lists.php.net>; Fri, 02 Aug 2013 12:55:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=xteHAVKvyrgXUzGTtlXb/iJn8NzuHqmj45bIxFqAOHk=;
        b=zWKwihZ/142hUw94AqjfbG+F6uKzab3KA6Ox8lRgnVnM/3fB1wmsJvTDg7iZL32Dbo
         3A9Byp41SgUcxnJQ9cpdvDcDcscGofFGK13SgQDaG5Ht+GxWlH5IKW6CsgoSbHhHaiek
         wmv/OO3jkE9xyjNpdeGy7Zim7F1w1nwKao/FUKyTGKv8hsKeRMcWedd9jREdoAb6ssGJ
         BDKxJeS3cOjUoY/l03E5XzSvdXISePvl8j7ZhK6+RqticU1ynWz9ZsbuHYIkTrZ44vgc
         fA07kjxFpMvnEccf9rQOZxPieEgqBxvYsPh1ZUen6GaLtoqd5+bs253ySjOvC7NnF3w4
         lzvA==
MIME-Version: 1.0
X-Received: by 10.182.224.135 with SMTP id rc7mr6441589obc.52.1375473304341;
 Fri, 02 Aug 2013 12:55:04 -0700 (PDT)
Received: by 10.76.81.167 with HTTP; Fri, 2 Aug 2013 12:55:04 -0700 (PDT)
In-Reply-To: <CAMUwpuQvz3X9HHK6c=ZWujDJig4YqaQMHs4peQUky=AjCPM3cA@mail.gmail.com>
References: <CAMUwpuQvz3X9HHK6c=ZWujDJig4YqaQMHs4peQUky=AjCPM3cA@mail.gmail.com>
Date: Fri, 2 Aug 2013 13:55:04 -0600
Message-ID: <CAFMT4Npdw8CUK42_fdBmWLR=ko9aYpfpjjQ-5YBpFh8s7aGEnA@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e014953a0b4151e04e2fc556e
Subject: Re: [PHP-DEV] Refactored magic methods
From: morrison.levi@gmail.com (Levi Morrison)

--089e014953a0b4151e04e2fc556e
Content-Type: text/plain; charset=ISO-8859-1

>
> If you have ideas or things to say, I'm listening.
> https://github.com/jpauli/php-src/compare/macroing


Is there a reason you switched from names like `__toString` to `__tostring`
(https://github.com/jpauli/php-src/compare/macroing#L2R12)?

Visually the macros clean things up a lot and better convey the intent
behind the if / else if chain. However, I don't really like having a macro
that works off of an `ELSE`, it just feels wrong. I don't have a better
suggestion though.

--089e014953a0b4151e04e2fc556e--