Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68352
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGcy7fPrCnH6N=LSY71aGOiXDbshV0afYGTJ7KCN+9WK0umVGA@mail.gmail.com>
References: <CAGcy7fMs11SjwaNrQ1zsRTQCbtQ46pCwdVkDrKXvbHsto48E7Q@mail.gmail.com>
 <CAGa2bXb7aif4fOiLvB31D6Gn-v3RQMxRbSOniXB=Lt1ZHwM_Zg@mail.gmail.com> <CAGcy7fPrCnH6N=LSY71aGOiXDbshV0afYGTJ7KCN+9WK0umVGA@mail.gmail.com>
Date: Thu, 1 Aug 2013 06:57:31 +0900
Message-ID: <CAGa2bXZYLsCuk-Bmxmj8e-yaka57HUdLYLh3R9Nh=g4_kf0G7A@mail.gmail.com>
To: Julien SALLEYRON <julien.salleyron@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0160b4325415f204e2d5d2eb
Subject: Re: [PHP-DEV] zend_execute_ex problem
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--089e0160b4325415f204e2d5d2eb
Content-Type: text/plain; charset=UTF-8

Hi Julien,

On Wed, Jul 31, 2013 at 10:05 PM, Julien SALLEYRON <
> julien.salleyron@gmail.com> wrote:
> >
> > The problem here is that I have came to the conclusion (wrong conclusion
> ?) that I need to update the EG(current_execute_data) "as if" the former
> called function had been processed, to actually skip the function that was
> called in PHP.
> >
>

I guess I understand what you would like to to. I might be wrong, though.


> >
> > Maybe some code will be more explicit...
> >
> > <?php
> >
> > myFunction(); //the function is expected to be called (and will)
> >
> >
> > $hook = function () {throw new Exception()};
> >
> > aop_add_before('myFunction()', $hook); //now we ask the extension to
> call hook() before myFunction()
> >
> > myFunction();//Now myFunction should never be called, as the hook is
> raising an exception
> >
> >
> > Extension-wise, the code is located here (
> https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L390), where I test if
> the hook raised an exception or not.
> >
> > If it did not, I'm calling the function (
> https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L392) and it ends up
> updating EG(current_execute_data) with
> EG(current_execute_data)->prev_execute_data.
> >
> > Now, when the hook is raising an exception, I'd like to just skip the
> function call. If I just "return" (
> https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L397) it ends up in an
> infinite loop. reason why I tried  EG (current_execute_data) =
> EG(current_execute_data)->prev_execute_data;
> >
> > But this solution ends up in memory headakes..


Unless you clean up EG(current_execute_data) by yourself, I suppose you'll
have memory issues.

If you would like to skip function to be executed, all you have to do is
"do not call zend_execute()/zend_execute_ex()" when the function is called.

> $hook = function () {throw new Exception()};

Since your code raise exception, you don't have to skip myfunction(). Just
let PHP die with unhandled exception.

It would be easier if you keep functions in hash to determine hooked one
and call hook as needed/skip function as needed. I might not understand
what you really would like to do, but hope this comment helps.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--089e0160b4325415f204e2d5d2eb--