Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68347
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXb7aif4fOiLvB31D6Gn-v3RQMxRbSOniXB=Lt1ZHwM_Zg@mail.gmail.com>
References: <CAGcy7fMs11SjwaNrQ1zsRTQCbtQ46pCwdVkDrKXvbHsto48E7Q@mail.gmail.com>
 <CAGa2bXb7aif4fOiLvB31D6Gn-v3RQMxRbSOniXB=Lt1ZHwM_Zg@mail.gmail.com>
Date: Wed, 31 Jul 2013 15:05:35 +0200
Message-ID: <CAGcy7fPrCnH6N=LSY71aGOiXDbshV0afYGTJ7KCN+9WK0umVGA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8ff2447bc8eabb04e2ce6249
Subject: Re: [PHP-DEV] zend_execute_ex problem
From: julien.salleyron@gmail.com (Julien SALLEYRON)

--e89a8ff2447bc8eabb04e2ce6249
Content-Type: text/plain; charset=UTF-8

>Hi Julien,

Hi and thank you for taking the time to help.

> Don't over write EG(execute_data), but use your own pointer when it is
needed. I think this will fix your problem.

The problem here is that I have came to the conclusion (wrong
conclusion ?) that I need to update the EG(current_execute_data) "as
if" the former called function had been processed, to actually skip
the function that was called in PHP.


Maybe some code will be more explicit...

<?php

myFunction(); //the function is expected to be called (and will)


$hook = function () {throw new Exception()};

aop_add_before('myFunction()', $hook); //now we ask the extension to
call hook() before myFunction()

myFunction();//Now myFunction should never be called, as the hook is
raising an exception


Extension-wise, the code is located here
(https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L390), where I test
if the hook raised an exception or not.

If it did not, I'm calling the function
(https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L392
<https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L391>) and it ends
up updating EG(current_execute_data) with
EG(current_execute_data)->prev_execute_data.

Now, when the hook is raising an exception, I'd like to just skip the
function call. If I just "return"
(https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L397
<https://github.com/AOP-PHP/AOP/blob/php5-5/aop.c#L396>) it ends up in
an infinite loop. reason why I tried  EG (current_execute_data) =
EG(current_execute_data)->prev_execute_data;

But this solution ends up in memory headakes...



2013/7/31 Yasuo Ohgaki <yohgaki@ohgaki.net>

> Hi Julien,
>
> On Wed, Jul 31, 2013 at 6:24 PM, Julien SALLEYRON <
> julien.salleyron@gmail.com> wrote:
>
>> If I EG(execute_data) = EG(execute_data)->prev_execute_data, there is no
>> loop anymore, but I have freeing error
>>
>
> Don't over write EG(execute_data), but use your own pointer when it is
> needed.
> I think this will fix your problem.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--e89a8ff2447bc8eabb04e2ce6249--