Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68339 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83845 invoked from network); 30 Jul 2013 22:55:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Jul 2013 22:55:52 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.192.180 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.192.180 mail-pd0-f180.google.com Received: from [209.85.192.180] ([209.85.192.180:59895] helo=mail-pd0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/AB-30402-67448F15 for ; Tue, 30 Jul 2013 18:55:51 -0400 Received: by mail-pd0-f180.google.com with SMTP id 15so3936pdi.25 for ; Tue, 30 Jul 2013 15:55:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=+d8xWdMYz7XMIWDaA3yO8g/G8V+wSPc/V7Xm5jWcrWA=; b=elJMGb5un1404Ni28Q9jo4kGhYYP4Nfh3/03gYaT2sMG8YU1Fh/zljs4jPPhSjEixe vFQOIqTojC1EyHPbPr/LKQi7RNuk540gEDvG0OIttP69QvPBg1sPyeAY3mtKyziJ+dQJ 2s2K8ER+ZG7M6NYsBSJxTJ73EFQXN/GB/6wkoykd9sd8/5lE9c71qJUIO7v8URMA1ecc XN2ToWDtrNqlSRFkb/pWwRUCLkWVaUGHpwPI1vTXeHuL25gswVSr4nMS+3QDGp34n6kg m2p9axpQxar2k+AE4PjXN0OCk7TVksW9CGHtfr37zvFYBApNaRjO+0bvc/Zhi8kWqj8r L/6w== MIME-Version: 1.0 X-Received: by 10.66.179.78 with SMTP id de14mr31589732pac.18.1375224947828; Tue, 30 Jul 2013 15:55:47 -0700 (PDT) Sender: php@golemon.com Received: by 10.70.128.71 with HTTP; Tue, 30 Jul 2013 15:55:47 -0700 (PDT) X-Originating-IP: [2620:0:1cfe:18:22c9:d0ff:fe87:295b] In-Reply-To: <51F63D70.70200@hristov.com> References: <51F63D70.70200@hristov.com> Date: Tue, 30 Jul 2013 15:55:47 -0700 X-Google-Sender-Auth: MXKJwQcEaSeXInbpFUqfXvvYUDQ Message-ID: To: Andrey Hristov Cc: PHP internals list Content-Type: multipart/alternative; boundary=047d7bea3cca807fc404e2c282fd X-Gm-Message-State: ALoCoQkfaybD+DMvCFgTmyYb5G9bMp7rE/z8S2iHmrf4epXUp7AzEWMxxrwcVz/yCGTBHYjnPkZT Subject: Re: [PHP-DEV] [PATCH] Constification of some PHP API calls From: pollita@php.net (Sara Golemon) --047d7bea3cca807fc404e2c282fd Content-Type: text/plain; charset=ISO-8859-1 At a glance, this looks awesome. There are a few changes where you introduced #ifdef WIN32 checks that I want to spend a little more time looking at... -Sara P.S. - Could I convince you to put it on a github fork to make it easier to read? No big deal if not... I just like that web view. :) On Mon, Jul 29, 2013 at 3:01 AM, Andrey Hristov wrote: > Hi, > after experiencing again warnings about conversion from const char * to > char * when calling some PHP API functions I decided to spend some time and > constify a few of these. The result is a patch that constifies the Streams > API, and few functions in Zend and TSRM (to which I have no karma). Most of > the changes are conversion of "char *" to "const char *" parameters, where > applicable. In a few places string lengths are changed from int to size_t. > Few functions return now "const char *" instead of "char *" (the caller did > not modify/release these before). > > The patch is against php-src because it changes API which can be only done > in a new version. > > Opinions? > > Best, > Andrey > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > --047d7bea3cca807fc404e2c282fd--