Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68333
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.53 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <51F63D70.70200@hristov.com>
References: <51F63D70.70200@hristov.com>
Date: Mon, 29 Jul 2013 16:35:22 +0200
Message-ID: <CAMUwpuQQLjk3h7dzqj3w-G14upk-2dp8e-hh_DZWA2QPZ_j=hA@mail.gmail.com>
To: Andrey Hristov <php@hristov.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c25004638bfe04e2a769f1
Subject: Re: [PHP-DEV] [PATCH] Constification of some PHP API calls
From: jpauli@php.net (Julien Pauli)

--001a11c25004638bfe04e2a769f1
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Jul 29, 2013 at 12:01 PM, Andrey Hristov <php@hristov.com> wrote:

>  Hi,
> after experiencing again warnings about conversion from const char * to
> char * when calling some PHP API functions I decided to spend some time and
> constify a few of these. The result is a patch that constifies the Streams
> API, and few functions in Zend and TSRM (to which I have no karma). Most of
> the changes are conversion of "char *" to "const char *" parameters, where
> applicable. In a few places string lengths are changed from int to size_t.
> Few functions return now "const char *" instead of "char *" (the caller did
> not modify/release these before).
>
> The patch is against php-src because it changes API which can be only done
> in a new version.
>
> Opinions?
>

I'm +1.

About strings sizes from int to size_t , you perhaps could sync with
Anthony who worked hard recently on such changes, especially regarding zval
string type.

Julien.Pauli

--001a11c25004638bfe04e2a769f1--