Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68302
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender)
MIME-Version: 1.0
Sender: ekneuss@gmail.com
In-Reply-To: <51ECE9DA.8040705@sugarcrm.com>
References: <51ECE9DA.8040705@sugarcrm.com>
Date: Wed, 24 Jul 2013 22:28:09 +0200
Message-ID: <CACQesk6RBcNprJu_Bp0ZYUpCRQywrxOfGxy7tard52miSM8C0A@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b673024a9b60d04e247c09b
Subject: Re: [PHP-DEV] warning in php_spl.c
From: colder@php.net (Etienne Kneuss)

--047d7b673024a9b60d04e247c09b
Content-Type: text/plain; charset=UTF-8

Hi Stas,


On Mon, Jul 22, 2013 at 10:14 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> Building PHP 5.5 with newer compiler on Mac, I'm getting this warning:
>
> /Users/smalyshev/php-5.5/ext/spl/php_spl.c:803:35: warning: format
> specifies type 'unsigned int' but the argument has type 'intptr_t'
>       (aka 'long') [-Wformat]
>         spprintf(&hex, 32, "%016x%016x", hash_handle, hash_handlers);
>                             ~~~~~        ^~~~~~~~~~~
>                             %016lx
> /Users/smalyshev/php-5.5/ext/spl/php_spl.c:803:48: warning: format
> specifies type 'unsigned int' but the argument has type 'intptr_t'
>       (aka 'long') [-Wformat]
>         spprintf(&hex, 32, "%016x%016x", hash_handle, hash_handlers);
>                                  ~~~~~                ^~~~~~~~~~~~~
>                                  %016lx
>
> Which suggests intptr_t there has wrong size. Looks like on 64-bit
> intptr_t would be too long and hash_handlers may not have chance to be
> in the hash. Anybody knows if there's a reason why this code is there?
>

The code is here to build the payload of what will be hashed to make what
spl_object_hash() returns.

I think it is safe to make it %016lx as suggested. Given the nature of this
function it is BC safe, and may indeed result in less collisions.

Best,

Best,


>
> BTW, llvm compiler produces tons of warnings on PHP source, I'm planning
> to get to them, probably next weekend.
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Etienne Kneuss
http://www.colder.ch

--047d7b673024a9b60d04e247c09b--