Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68299 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69011 invoked from network); 24 Jul 2013 16:21:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jul 2013 16:21:10 -0000 Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.54 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.219.54 mail-oa0-f54.google.com Received: from [209.85.219.54] ([209.85.219.54:43543] helo=mail-oa0-f54.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2C/69-07084-3FEFFE15 for ; Wed, 24 Jul 2013 12:21:08 -0400 Received: by mail-oa0-f54.google.com with SMTP id o6so1503018oag.13 for ; Wed, 24 Jul 2013 09:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bjlYg1suAsAyPNJWyjEu4j/7HKOYNYfmR7HbUbJGTnU=; b=NxiOc859AchxGYvIoHT57J3GAQrgfdUkEt4BDHFl+u8twJf7btR2ZkuMQRxpyInhqu pQGQXJChoACAKoWJ5t0hCHbOh9+tM9C1FPRp9qvVhPmWn43auUrBm38yWh38EYUYSw2E 4eQZYYb0FTZ3VmrcPll+xC0b0xRzStD1KyE4uWin7VzjCgGcgVM8CAfPZZKwGwPT5aaF 9U8j8jgrD/ilCXfmCOp+uoMNK7D+IdSWwupCjadw5luaazJoQjG8ha898nReLsOQhgM1 NbDUthJya/EqQVy2gWKc6l6D1KzUMA8QsApmiolAYlIctw5G7A8vZUR9ug+fwDMwemUj l5zw== MIME-Version: 1.0 X-Received: by 10.50.44.35 with SMTP id b3mr524977igm.7.1374682862189; Wed, 24 Jul 2013 09:21:02 -0700 (PDT) Received: by 10.50.65.8 with HTTP; Wed, 24 Jul 2013 09:21:02 -0700 (PDT) In-Reply-To: <51ECE8C8.7070001@sugarcrm.com> References: <51ECE8C8.7070001@sugarcrm.com> Date: Wed, 24 Jul 2013 18:21:02 +0200 Message-ID: To: Stas Malyshev , Ralph Schindler Cc: PHP Internals Content-Type: multipart/alternative; boundary=047d7bdcab2eae11a504e2444beb Subject: Re: [PHP-DEV] phar bug #65028 From: tyra3l@gmail.com (Ferenc Kovacs) --047d7bdcab2eae11a504e2444beb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable hi we don't have a maintainer for phar as far as I know. Ralph volunteered(twice) to take over phar but was pretty much ignored. He is the last person that I know looking into the phar code and fixing stuff so maybe he could review your changes. On Mon, Jul 22, 2013 at 10:09 AM, Stas Malyshev wro= te: > Hi! > > I was looking at bug https://bugs.php.net/bug.php?id=3D65028 and looks > like it happens because phar writes manifest after HALT_COMPILER(); ?> > and first 4 bytes of manifest are manifest length (little-endian), but > when it read the header, it checks if there's \r\n after ?>. So if > length has lowest byte 0x0d or 0x0a, bad things happen. > > I've created https://github.com/php/php-src/pull/392 to fix this > problem, however I'd like somebody with more familiarity with phar > details to take a look if it's the best way to do it. > > P.S.: BTW, who is official phar maintainer now? I'm seeing that last > commit from anybody listed as maintainer is 4 years ago... Is it time to > update ownership? > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu --047d7bdcab2eae11a504e2444beb--