Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68277
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.91 as permitted sender)
Message-ID: <51ECE9DA.8040705@sugarcrm.com>
Date: Mon, 22 Jul 2013 01:14:18 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
MIME-Version: 1.0
To: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: warning in php_spl.c
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

Building PHP 5.5 with newer compiler on Mac, I'm getting this warning:

/Users/smalyshev/php-5.5/ext/spl/php_spl.c:803:35: warning: format
specifies type 'unsigned int' but the argument has type 'intptr_t'
      (aka 'long') [-Wformat]
        spprintf(&hex, 32, "%016x%016x", hash_handle, hash_handlers);
                            ~~~~~        ^~~~~~~~~~~
                            %016lx
/Users/smalyshev/php-5.5/ext/spl/php_spl.c:803:48: warning: format
specifies type 'unsigned int' but the argument has type 'intptr_t'
      (aka 'long') [-Wformat]
        spprintf(&hex, 32, "%016x%016x", hash_handle, hash_handlers);
                                 ~~~~~                ^~~~~~~~~~~~~
                                 %016lx

Which suggests intptr_t there has wrong size. Looks like on 64-bit
intptr_t would be too long and hash_handlers may not have chance to be
in the hash. Anybody knows if there's a reason why this code is there?

BTW, llvm compiler produces tons of warnings on PHP source, I'm planning
to get to them, probably next weekend.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227