Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68168
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.214.169 cause and error)
MIME-Version: 1.0
In-Reply-To: <51E83B38.2010301@sugarcrm.com>
References: <CAPJnDK3BjUG33oudBkk9VisEkEB6HGrcWsyoASNhbvrsPWF=Dw@mail.gmail.com>
	<CAL+t6cF5T159-7hnSa5CQuL1EV8+zC=AsUOHg6-KcYqT2-sDXw@mail.gmail.com>
	<CAPJnDK01o55P4tonCOz6fkhPb-wUMJCtQmBE9RNZiuqwoifjLA@mail.gmail.com>
	<51E83B38.2010301@sugarcrm.com>
Date: Thu, 18 Jul 2013 22:57:57 +0300
Message-ID: <CAPJnDK0mV9Zqpyo8+qy6oqOpMjkn3hWfbji0xed87aUAptvc+g@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c1c00c6d0d2804e1cea04e
Subject: Re: [PHP-DEV] Pull requests report (17/7/2013)
From: lior.k@zend.com (Lior Kaplan)

--001a11c1c00c6d0d2804e1cea04e
Content-Type: text/plain; charset=UTF-8

On Thu, Jul 18, 2013 at 10:00 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> > Also, we have more than a few PR which the patch is OK, but are stuck due
> > to a
> > missing test. This is fair enough, but should also have some rule of
> thumb
> > for
> > these cases.
>
> Again, it would not be hard to add tests for many of them, the problem
> is again - time. For myself, I'd rather spend time on merging properly
> done patches or fixing bugs than finishing up patches that the original
> author could finish up. But if some people decide that this is a good
> way for them to contribute - that'd be great. Otherwise, removing these
> pulls from public view would only mean they'd never get taken care at all.


Maybe offer the list of needed tests as an easy task/hack so even people
not into
the internals could contribute. e.g.
https://wiki.documentfoundation.org/Easy_Hacks

Might be a win win for everybody ? (although some help might still be
needed)

Kaplan

--001a11c1c00c6d0d2804e1cea04e--