Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68140
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbEJXC8qRs+0UTLvjnq1_TgsuL-cXkSaBafoAd2r4XaCw@mail.gmail.com>
References: <CAPJnDK3BjUG33oudBkk9VisEkEB6HGrcWsyoASNhbvrsPWF=Dw@mail.gmail.com>
	<CAL+t6cF5T159-7hnSa5CQuL1EV8+zC=AsUOHg6-KcYqT2-sDXw@mail.gmail.com>
	<CAGa2bXbEJXC8qRs+0UTLvjnq1_TgsuL-cXkSaBafoAd2r4XaCw@mail.gmail.com>
Date: Thu, 18 Jul 2013 00:05:24 -0400
Message-ID: <CAL+t6cHyodhb4Q8KB7K5u1r+rfr_gLKNxpeciuWZ0TW4YOZezg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Lior Kaplan <lior.k@zend.com>, PHP internals list <internals@lists.php.net>, 
	Veres Lajos <vlajos@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c2404cd7bd3604e1c151da
Subject: Re: [PHP-DEV] Pull requests report (17/7/2013)
From: theanomaly.is@gmail.com (Sherif Ramadan)

--001a11c2404cd7bd3604e1c151da
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Jul 17, 2013 at 11:21 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Sherif,
>
> 2013/7/18 Sherif Ramadan <theanomaly.is@gmail.com>
>
>> First off, thanks for all the hard work. PRs aren't getting as much
>> attention as they should, and I'd like to say that I certainly haven't
>> been
>> helping as much as I should with them.
>>
>
> We may have bugs ML and PR ML so that any discussion, then it may
> have more attentions.
>
> Bugs ML may have too many mails, but PR ML would have much less mails.
> It may be good idea that redirect PR discussion to internals, if it is
> possible.
>
>
>
Well, some people may not be paying attention to the discussion on github
about certain PRs and that's OK. Some people may not fully understand or
have enough knowledge in one particular area to be able to help with that
PR. Perfectly fine.

However, I don't think that THIS is the reason PRs aren't getting their
fair share of attention, honestly. For example, look at the oldest PR
sitting around for over a year now
https://github.com/php/php-src/pull/15 plenty
of discussion there. Lots of criticism, suggestions, etc... All of that is
wonderful. People are participating!

Then all of a sudden the people involved in the discussion seem to
mysteriously disappear and nothing happens to the PR. It just sits in limbo
indefinitely. This is not the only PR I've seen follow this pattern.

I assure you the discussion on github and the mailing lists are not the
reason we've got stagnate PRs.

--001a11c2404cd7bd3604e1c151da--