Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68076 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31596 invoked from network); 8 Jul 2013 16:54:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jul 2013 16:54:49 -0000 Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain oracle.com designates 141.146.126.69 as permitted sender) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 141.146.126.69 aserp1040.oracle.com Received: from [141.146.126.69] ([141.146.126.69:33181] helo=aserp1040.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/C1-18779-7DEEAD15 for ; Mon, 08 Jul 2013 12:54:47 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r68GshBn019878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 8 Jul 2013 16:54:44 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r68GsgDp026855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 8 Jul 2013 16:54:43 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r68GsgPr029725 for ; Mon, 8 Jul 2013 16:54:42 GMT Received: from [130.35.70.82] (/130.35.70.82) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Jul 2013 09:54:42 -0700 Message-ID: <51DAEED1.2010800@oracle.com> Date: Mon, 08 Jul 2013 09:54:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: internals@lists.php.net References: <51D97BC0.9010102@php.net> <51D9814F.4040005@php.net> In-Reply-To: <51D9814F.4040005@php.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Subject: Re: [PHP-DEV] --enable-debug and GCC 4.8 / -Og From: christopher.jones@oracle.com (Christopher Jones) On 07/07/2013 07:55 AM, Sebastian Bergmann wrote: > On 07/07/2013 04:31 PM, Sebastian Bergmann wrote: >> Currently "--enable-debug" sets "-O0". I think it would make sense to >> use "-Og" instead when GCC >= 4.8.0 is used. > > https://gist.github.com/sebastianbergmann/5943708 is an attempt to > implement this. Only tested this on Fedora 19. > Seems reasonable. Your test logic needs fixing. It should be like: "if ((major > 4) || (major == 4 && minor >= 8))" Chris -- christopher.jones@oracle.com http://twitter.com/ghrd Free PHP & Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html