Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68066
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 19037 invoked from network); 4 Jul 2013 04:56:27 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 4 Jul 2013 04:56:27 -0000
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 209.85.217.172 mail-lb0-f172.google.com  
Received: from [209.85.217.172] ([209.85.217.172:43521] helo=mail-lb0-f172.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 5F/B1-02453-97005D15 for <internals@lists.php.net>; Thu, 04 Jul 2013 00:56:26 -0400
Received: by mail-lb0-f172.google.com with SMTP id v20so850234lbc.31
        for <internals@lists.php.net>; Wed, 03 Jul 2013 21:56:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=tI0GTSnxAISqFEN4eXh5IeUVKrhbkcyQC5I3+O2ERlo=;
        b=x1Z3YDDBkWF+Kv4V9QvNJhoCBZ/XWpi/vOvMgl8Fs2vPSWmgmnAcSoxAQ61bqPhDee
         rE3TjlrvPfvXs0tgxkFeQu7DjtiDY585eZuHIJ+dnbhfc8Y/2udK2lNT7/4g6PjYFRdj
         fmDa2yO1G+BbLn6XJL+8MjUB+WiQQoIsJuc6TrIqkhCyA9qzF7YjCHyw0l1PsUIRv6mk
         cKKxBpScDCm13AdzxkQBYTa0IJ6zhxCTnKbPmLNtx2BjeGPxx2pWwn51EtS2xiZsod7C
         K2HNMHf9GthNv6jgGwYZLbtdw87XBRXTp22pbK7ps44YM71v5yZ31etTjV6i+OTAa1aG
         e0Gg==
MIME-Version: 1.0
X-Received: by 10.112.181.71 with SMTP id du7mr2641601lbc.24.1372913782257;
 Wed, 03 Jul 2013 21:56:22 -0700 (PDT)
Received: by 10.112.160.4 with HTTP; Wed, 3 Jul 2013 21:56:21 -0700 (PDT)
Received: by 10.112.160.4 with HTTP; Wed, 3 Jul 2013 21:56:21 -0700 (PDT)
In-Reply-To: <CAGa2bXZapgMVXwxAZAVN6uWLdTxp+Xiz8y8eqmM86WemVa2c+A@mail.gmail.com>
References: <CAAyV7nG8R03TTETSeA49ELoKLhn0b5CWWMQhTpSMWfGQRprUaA@mail.gmail.com>
	<CAGa2bXZapgMVXwxAZAVN6uWLdTxp+Xiz8y8eqmM86WemVa2c+A@mail.gmail.com>
Date: Thu, 4 Jul 2013 06:56:21 +0200
Message-ID: <CAEZPtU4d+gfS-8iJThUZvmuffQgU_4JJjv+26QM9+fTM_n+eCw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: PHP internals <internals@lists.php.net>, Anthony Ferrara <ircmaxell@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c3715c4c7b6304e0a86630
Subject: Re: [PHP-DEV] String Size Refactor Progress
From: pierre.php@gmail.com (Pierre Joye)

--001a11c3715c4c7b6304e0a86630
Content-Type: text/plain; charset=ISO-8859-1

Hi Yasuo,

On Jul 4, 2013 5:54 AM, "Yasuo Ohgaki" <yohgaki@ohgaki.net> wrote:
>
> Hi Anthony,
>
> 2013/7/3 Anthony Ferrara <ircmaxell@gmail.com>
>
> > I've migrated php_pcre.c over, but pcrelib still uses int for string
sizes.
> > This is going to be a much larger refactor, and I wanted to see people's
> > thoughts prior to digging into it.
> >
>
> For upgradability and compatibility, bundled pcrelib should be left as
> it is. Instead, checking possible over/under flow before passes string is
> better.

Or ask pcre to use size_t as well for their next major version.

Cheers,
Pierre

--001a11c3715c4c7b6304e0a86630--