Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68054
Return-Path: <ircmaxell@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 74408 invoked from network); 3 Jul 2013 18:21:07 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 3 Jul 2013 18:21:07 -0000
Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.171 as permitted sender)
X-PHP-List-Original-Sender: ircmaxell@gmail.com
X-Host-Fingerprint: 209.85.220.171 mail-vc0-f171.google.com  
Received: from [209.85.220.171] ([209.85.220.171:48044] helo=mail-vc0-f171.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 56/C7-30639-29B64D15 for <internals@lists.php.net>; Wed, 03 Jul 2013 14:21:07 -0400
Received: by mail-vc0-f171.google.com with SMTP id gd11so339332vcb.2
        for <internals@lists.php.net>; Wed, 03 Jul 2013 11:21:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=eO2xKRHQloLvdzzN+HbJ6qMEnpR6aT4lEvbWNGq7pZQ=;
        b=iHNItb1t7ZGwjIUtRGjIOw5+NjUt7frMQEdtMjyt6pZ39MB4vgosjvquscFRFZKQ44
         ILJnuEYnD1FScOMmQ217/a99Em8ekxlfXOcr7NZcVOpXXErF60XTPMzuUsN7wZv5n2UG
         cK/jMtRy4Dr0G2lNkTI0BOevbX/6QBCU1ixlEbmQ9JSgztYlNsYUsB4F608TBRYXxqA+
         mG/gVt4DdezPigrJKtdaxbOhVwvYW1PL9lsU2obp31LjOQEOwgINfY1Yh/fxIVyPy/9x
         LwW65cDVhyaEGrgEYbmHUMg/dMZ9Jw/KPZKdH+KfTjjsaHI+BF0pxZb+WW5/LWZs/jVo
         4VGQ==
MIME-Version: 1.0
X-Received: by 10.52.33.47 with SMTP id o15mr581449vdi.1.1372875663456; Wed,
 03 Jul 2013 11:21:03 -0700 (PDT)
Received: by 10.58.94.201 with HTTP; Wed, 3 Jul 2013 11:21:03 -0700 (PDT)
In-Reply-To: <51D46AA9.6040108@oracle.com>
References: <CAAyV7nG8R03TTETSeA49ELoKLhn0b5CWWMQhTpSMWfGQRprUaA@mail.gmail.com>
	<51D46AA9.6040108@oracle.com>
Date: Wed, 3 Jul 2013 14:21:03 -0400
Message-ID: <CAAyV7nFjNGcvr3RiTtL1Fk=9mNNjxG6iX2uVmAGn4f12Op=CaA@mail.gmail.com>
To: Christopher Jones <christopher.jones@oracle.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf307ca1843dc26d04e09f8608
Subject: Re: [PHP-DEV] String Size Refactor Progress
From: ircmaxell@gmail.com (Anthony Ferrara)

--20cf307ca1843dc26d04e09f8608
Content-Type: text/plain; charset=ISO-8859-1

Chris,


When `--enable-zstrlen` is not enabled, I disable s and p, and changed ZPP
>> to rase an E_ERROR on unknown parameter types. The E_ERROR change is not
>> intended to go into production, but instead just makes life A LOT easier
>> refactoring modules one at a time.
>>
>
> Can you elaborate on the "problem"?  Ideally the return type of s & p would
> be toggled by ZEND_USE_LEGACY_STRING_TYPES
>

The problem is that changing 's' from int to size_t can (and does) cause
segfaults.

We can have the discussion if 's' and 'p' should remain there (and if the
compile time option should be there) at merge time, but for now the switch
just makes life easier making the change. It wasn't designed for a
long-term switch...

Anthony

--20cf307ca1843dc26d04e09f8608--