Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68053 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 72950 invoked from network); 3 Jul 2013 18:17:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jul 2013 18:17:21 -0000 Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain oracle.com designates 141.146.126.69 as permitted sender) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 141.146.126.69 aserp1040.oracle.com Received: from [141.146.126.69] ([141.146.126.69:35613] helo=aserp1040.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 80/77-30639-FAA64D15 for ; Wed, 03 Jul 2013 14:17:20 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r63IHEQn010560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 3 Jul 2013 18:17:15 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r63IHEnI007067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Jul 2013 18:17:14 GMT Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r63IHDUI004069; Wed, 3 Jul 2013 18:17:13 GMT Received: from [130.35.70.82] (/130.35.70.82) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Jul 2013 11:17:13 -0700 Message-ID: <51D46AA9.6040108@oracle.com> Date: Wed, 03 Jul 2013 11:17:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Anthony Ferrara CC: "internals@lists.php.net" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Subject: Re: [PHP-DEV] String Size Refactor Progress From: christopher.jones@oracle.com (Christopher Jones) On 07/03/2013 07:12 AM, Anthony Ferrara wrote: > Then, I defined a series of new types: > > #ifdef ZEND_USE_LEGACY_STRING_TYPES > Due to a problem with zend_parse_parameters, I added two new identifiers: S > and P. They act just like s and p, except that they return zend_str_size > instead of int. > > When `--enable-zstrlen` is not enabled, I disable s and p, and changed ZPP > to rase an E_ERROR on unknown parameter types. The E_ERROR change is not > intended to go into production, but instead just makes life A LOT easier > refactoring modules one at a time. Can you elaborate on the "problem"? Ideally the return type of s & p would be toggled by ZEND_USE_LEGACY_STRING_TYPES. Chris -- christopher.jones@oracle.com http://twitter.com/ghrd Free PHP & Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html