Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68034
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.178 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <51D287B7.5050605@beccati.com>
References: <CAGa2bXYEG+WnmgE630UODk9NsN4UwrFHMyQMgAfOpqL8-58+BA@mail.gmail.com>
 <51D287B7.5050605@beccati.com>
Date: Tue, 2 Jul 2013 19:34:34 +0900
Message-ID: <CAGa2bXZzompT+rVyNhoO0p5hXJY5PCV7AYPUnWExCvASyyPXpw@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf303346517e0ca204e084e62d
Subject: Re: [PHP-DEV] Adding E_WARNING to pg_unescape_bytea()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--20cf303346517e0ca204e084e62d
Content-Type: text/plain; charset=ISO-8859-1

Hi Matteo,

2013/7/2 Matteo Beccati <php@beccati.com>

> Raising an E_WARNING will most likely mean that it needs to be
> suppressed in some way, which I think is not necessary.
>
> I'm all for returning false when the input is invalid. However, given
> the behaviour change, I suppose it would be PHP 5.next material.
>

If pg_unecape_bytea() returns FALSE, it means there is obvious bug
or some kind of attack.

Users should be prepared for unexpected errors not only pg_escape_bytea()
but also many other functions anyway.

It does not hart any application, so it's good to have 5.5. IMHO.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--20cf303346517e0ca204e084e62d--