Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:68030 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49620 invoked from network); 2 Jul 2013 07:57:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Jul 2013 07:57:17 -0000 Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.114.167 spritz.beccati.com Received: from [176.9.114.167] ([176.9.114.167:34977] helo=mail.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 80/E4-09174-BD782D15 for ; Tue, 02 Jul 2013 03:57:16 -0400 Received: (qmail 18100 invoked from network); 2 Jul 2013 07:57:11 -0000 Received: from home.beccati.com (HELO ?192.168.1.202?) (88.149.176.119) by mail.beccati.com with SMTP; 2 Jul 2013 07:57:11 -0000 Message-ID: <51D287B7.5050605@beccati.com> Date: Tue, 02 Jul 2013 09:56:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yasuo Ohgaki CC: "internals@lists.php.net" References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Adding E_WARNING to pg_unescape_bytea() From: php@beccati.com (Matteo Beccati) Hi Yasuo, > pg_unescape_bytea() should raise error for invalid inputs > https://bugs.php.net/bug.php?id=65165 > > We need to discuss if E_WARING is proper, which branch should be > changed. > > It will not break working code, so I would like to use E_WARNING and > change it from PHP 5.4. Raising an E_WARNING will most likely mean that it needs to be suppressed in some way, which I think is not necessary. I'm all for returning false when the input is invalid. However, given the behaviour change, I suppose it would be PHP 5.next material. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/