Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:68014
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.46 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAL+t6cHhTNFcR2JP9PTqhQAOu9rmOvViy2urYeF_QYb0JNg0Vg@mail.gmail.com>
References: <CAGa2bXYNgjhUWTqzhorcYhd7SEyEvxdhCVWyXr8O-hsZ103E6g@mail.gmail.com>
 <CAGa2bXYBR-=rrifyhWSwB7M1u5J5EL_0o0DcUuFZ9DEuMCrjjQ@mail.gmail.com>
 <CAL+t6cGUJmfhVdSCf3XNn4Mri_fvq-Fuad40yrrKOd8c1uwxXw@mail.gmail.com>
 <51CD5580.50103@gmail.com> <CAL+t6cHhTNFcR2JP9PTqhQAOu9rmOvViy2urYeF_QYb0JNg0Vg@mail.gmail.com>
Date: Sat, 29 Jun 2013 10:41:10 +0900
Message-ID: <CAGa2bXb3Uw=mi3bZ=1fKbknwDXQA8H15Nxny84zDAbWtUTW2TQ@mail.gmail.com>
To: Sherif Ramadan <theanomaly.is@gmail.com>
Cc: =?ISO-8859-2?Q?Leszek_Krupi=F1ski?= <leafnode@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c37b0a6f084504e0411917
Subject: Re: [PHP-DEV] Re: hex2bin: E_WARNING is too much for odd string?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c37b0a6f084504e0411917
Content-Type: text/plain; charset=ISO-8859-1

Hi Sherif,

The problem is that current code 'returns false for invalid hex' while it
'returns false and E_WARNING for invalid length'.

We may choose behavior for invalid inputs
 - return false always
 - return false and raise E_WARNING always

Mixing them up is not good, especially in the same function. IMHO. PHP has
enough inconsistency. We should try to remove inconsistency much as
possible. Besides the change will not break code as long as it is used as
it should be.

Considering the use case of hex2bin(), it will not handle external inputs
in most cases. Therefore, it's better to raise errors invalid inputs. Do
you prefer not to raise errors?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c37b0a6f084504e0411917--