Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:680
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: Sascha Schumann <sascha@schumann.cx>
Cc: internals@lists.php.net
In-Reply-To: <Pine.LNX.4.53.0304041840120.804@eco.foo>
References: <1049472559.6067.32.camel@hasele>
	 <Pine.LNX.4.53.0304041840120.804@eco.foo>
Content-Type: text/plain
Organization: 
Message-ID: <1049474684.6163.47.camel@hasele>
Mime-Version: 1.0
Date: 04 Apr 2003 11:44:44 -0500
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] If you want to avoid annoying CS commits
From: sterling@bumblebury.com (Sterling Hughes)

On Fri, 2003-04-04 at 11:54, Sascha Schumann wrote:
>     Sterling, you are missing some important points here.
> 
> > Geeze Luise, its not that hard, and the coding standards are there for a
> > (good) reason.  If you object to some of the standards, discuss that,
> 
>     If you look at my code, 99% of it follows the coding styles,
>     because I've adopted the PHP style as my personal one.
> 
>     The commit I recently backed out related mostly to Zeev's
>     "terse" style.  While I'm not particular fond of it, there is
>     also no reason why it absolutely has to be realigned.
> 
>     I barked at Derick for trying to police me with his docref
>     pet stuff.  I just noticed that someone has committed that to
>     CODING_STANDARDS, although there has never been a consensus
>     regarding its introduction.  As such, I consider it to be
>     void.
> 

Ahh, well, you should follow the coding standards regardless, or rather
change them.  I've just removed docref and assert bogusness from the
files, so, in that case, you are no longer in violation. (you should
throw a party. ;-)

What I was objecting to was less contraversial, long term coding
standards, for example:

if (foo) bar = 1;

instead of :

if (foo) {
	bar = 1;
}

Its really quite simple to follow, and if you want to avoid annoying CS
commits, just follow the standards.

-Sterling
-- 
"The three most dangerous things in the world are a programmer  
 with a soldering iron, a hardware type with a program patch and  
 a user with an idea." 
    - Unknown