Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67997
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <51CBF60C.9080706@b1-systems.de>
References: <51CBF60C.9080706@b1-systems.de>
Date: Fri, 28 Jun 2013 13:12:03 +0800
Message-ID: <CABBJUpeeYkd3Aaxx-JSY9M+Qib_MTsvJXM60HoGoY1DgVBd+Lg@mail.gmail.com>
To: Ralf Lang <lang@b1-systems.de>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G
From: laruence@php.net (Laruence)

Hey:

 Instead of change the uint to long or size_t,   Maybe make the
max_file_upload_size 0 means unlimited? like Apached did, ulimited or
<=3D 2Gb

 https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestbody

thanks

On Thu, Jun 27, 2013 at 4:21 PM, Ralf Lang <lang@b1-systems.de> wrote:
> Hi,
>
> I want to deal with Bug 44522 which disallows uploads > 2G
> https://bugs.php.net/bug.php?id=3D44522&edit=3D1
>
> Today with PHP cloud solutions, we are running into more situations
> where this really hurts.
>
> Before I begin providing a github patch (as I have no php svn access and
> I don't think it's needed) against master and possibly 5.5.next:
>
> Does anybody know of intricate reasons why the existing patch
>
> https://bugs.php.net/patch-display.php?bug_id=3D44522&patch=3Duploads_lar=
ger_than_2g_HEAD_v2&revision=3Dlatest
>
> could not be included into php 5.5?
>
> Or is it only what stas said in 2012:
>
> "The patch however
> needs to be cleaned up (no IGNORE vars, etc.) and changing signature for
> zend_atoi may not be safe if any code out there presumes it returns int
> (integer
> overflow). Also, no reason to use signed long there where we used
> unsigned long."
>
> This would be my first patch against php core. Any pointers apreciated.
>
>
> --
> Ralf Lang
> Linux Consultant / Developer
> Tel.: +49-170-6381563
> Mail: lang@b1-systems.de
> B1 Systems GmbH
> Osterfeldstra=C3=9Fe 7 / 85088 Vohburg / http://www.b1-systems.de
> GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
>



--=20
Laruence  Xinchen Hui
http://www.laruence.com/