Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67988 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 49060 invoked from network); 28 Jun 2013 01:28:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jun 2013 01:28:38 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.181 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.181 mail-lb0-f181.google.com Received: from [209.85.217.181] ([209.85.217.181:64434] helo=mail-lb0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 95/36-34034-4C6ECC15 for ; Thu, 27 Jun 2013 21:28:37 -0400 Received: by mail-lb0-f181.google.com with SMTP id w10so731912lbi.26 for ; Thu, 27 Jun 2013 18:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=eqKaN4fq6YwXqYpa97NSHRbvmqyVERGn/oLDPgxX3R4=; b=DqAYRkt2Us/08e/aTncYGS/yLr56yaz845iAUW1QqUTMB/jGNkru9Pt3MFVLS+55SX 0/e7TpIIa2tOvfd9kmizRAUBUGjHGk+PTMdzz8+bm9XSnJP/Bc7mV4OPeCd6j/iz/Pxg WmhltUxDAEL3sR516MXilX5sJGb17hIL+5ZnJWxre54rKSdqu7jbXxJpIYjU9LoKN2eo kQqC55Haf/6Zqdq5GT1dbCLB9D9eFj/KzSWEWVmOVcKiI15hQH0gn2wi5vE//94Pmyk3 8eUwuRGoFlv5BzuhVuq+Qr8ld5SpQCfip8LO5SyiHpbIN75pJEsJxC9+Pj6ldXx8k1pW HMsQ== X-Received: by 10.152.28.199 with SMTP id d7mr5391868lah.67.1372382913642; Thu, 27 Jun 2013 18:28:33 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.4.233 with HTTP; Thu, 27 Jun 2013 18:27:53 -0700 (PDT) In-Reply-To: References: Date: Fri, 28 Jun 2013 10:27:53 +0900 X-Google-Sender-Auth: QJ7xHD7q2z19vaCG6hwXnoYJOug Message-ID: To: Tjerk Meesters Cc: Sherif Ramadan , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e0160b432104b2c04e02ccce1 Subject: Re: [PHP-DEV] Re: hex2bin: E_WARNING is too much for odd string? From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e0160b432104b2c04e02ccce1 Content-Type: text/plain; charset=ISO-8859-1 Hi Tjerk, 2013/6/27 Tjerk Meesters > The thread started with the assertion that it raises a warning and the > commits first remove the warning and then adds it again later, so isn't the > whole PR a noop? :) The issue is inconsistent behavior of hex2bin against invalid inputs. Both removing and adding E_WARNING provide consistency. Adding E_WARNING is better than removing as a result discussion, IMO. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.netHi --089e0160b432104b2c04e02ccce1--