Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67986 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35646 invoked from network); 27 Jun 2013 22:13:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2013 22:13:45 -0000 Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.171 as permitted sender) X-PHP-List-Original-Sender: ircmaxell@gmail.com X-Host-Fingerprint: 209.85.128.171 mail-ve0-f171.google.com Received: from [209.85.128.171] ([209.85.128.171:62407] helo=mail-ve0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 22/44-34034-719BCC15 for ; Thu, 27 Jun 2013 18:13:44 -0400 Received: by mail-ve0-f171.google.com with SMTP id b10so1240610vea.2 for ; Thu, 27 Jun 2013 15:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Z4BAIPLFzr1cqyBTUga5TakFptqLmAEJxyMvAaML0ag=; b=bZ6mwa/yJS9no/beMqT8nKSO4P/wtbjUd/7uXotyYbzcBlYD+bi2VM72UqIt/wZok3 bTC+YDGUXHHRG0wTu4OZBkgJDS0sfus0kN9BakZpRDCbThV9p584oi9oGZD2fJ03UlO5 Wyfrzn49dvo6IY5ynZ+JO02JE+3l/HzumUk0e6/s2CjXY7YUxsmdsCPGlGJDCq1W140U MsPuQqi0XqPBuAY0fntOIkuVd4EGkVrljlpCm3F57hAb9VvSWaHa3Crg3yCYFYQnBzgo aBGQbD0ZMqwLrsQvryi1LDQVgFWZXnb13NpodZfsQ3lCfvpbtXTPdonenjNRTf60C98E hxvQ== MIME-Version: 1.0 X-Received: by 10.58.97.138 with SMTP id ea10mr4306701veb.38.1372371219900; Thu, 27 Jun 2013 15:13:39 -0700 (PDT) Received: by 10.58.94.201 with HTTP; Thu, 27 Jun 2013 15:13:39 -0700 (PDT) In-Reply-To: References: <51CBF60C.9080706@b1-systems.de> Date: Thu, 27 Jun 2013 18:13:39 -0400 Message-ID: To: Yasuo Ohgaki Cc: Ralf Lang , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e013a28600ff54404e02a1381 Subject: Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G From: ircmaxell@gmail.com (Anthony Ferrara) --089e013a28600ff54404e02a1381 Content-Type: text/plain; charset=ISO-8859-1 To be fair, the overall limit is going to be 32 bit anyway (due to the use of int for string lengths)... I'm working on a patch to replace all references of string sizes with size_t, but as you can imagine, it's going to take some time... Just throwing it out there that a better fix may be coming down the road anyway. I'll post on-list in the coming days about this... Anthony On Thu, Jun 27, 2013 at 5:47 PM, Yasuo Ohgaki wrote: > Hi > > Just a comment for the patch. > > 2013/6/27 Ralf Lang > > > Does anybody know of intricate reasons why the existing patch > > > > > > > https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest > > > > could not be included into php 5.5? > > > > It uses long instead of uint but it makes large files available only to > 64bit platforms. > > It should use off_t along with "#define _FILE_OFFSET_BITS 64", but I'm not > sure if this work under windows. There may be other places that data type > should be changed. It should be checked carefully, otherwise memory fault > may occur due to integer overflow. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > --089e013a28600ff54404e02a1381--