Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67985
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 31909 invoked from network); 27 Jun 2013 21:48:08 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 27 Jun 2013 21:48:08 -0000
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.215.43 mail-la0-f43.google.com  
Received: from [209.85.215.43] ([209.85.215.43:40911] helo=mail-la0-f43.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 2D/73-34034-613BCC15 for <internals@lists.php.net>; Thu, 27 Jun 2013 17:48:07 -0400
Received: by mail-la0-f43.google.com with SMTP id gw10so1450178lab.30
        for <internals@lists.php.net>; Thu, 27 Jun 2013 14:48:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type;
        bh=jD/TgOB72MGIifEY7i1PuOoTC5ZL4K37azM1AtHxAzc=;
        b=BJDdSBmdh4quAMK2ivLCjiclbFFomnTUsgUllNdnDxIEFD49csFYZAWv5FVK7Ho+u0
         crhrjTDdoNQ3paEx9aSjp2salTu5PaVmiI3BYSBFmZDIzykc9yhJ1FonLD+xv5VtQQM3
         9MwtJDvM17B0hi/8Ikg2KJgi0W1JL+0RmsDTE55wvLtBUsJ6ffOVirnsS2hrhtbuqu64
         RbMiMLhSQJxQD49POPXptPf/ypMnlNugg2KTXpexPv7i5GEK8gazXa1LDUS94T9aLoB7
         eX0+l4vWVRwNIF5dk0NWyX0ZipBomHw8y+seccfthH7WpNeXS5k1/FZMa2+SZUUpZa5d
         azoA==
X-Received: by 10.152.7.74 with SMTP id h10mr5120803laa.83.1372369683829; Thu,
 27 Jun 2013 14:48:03 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.112.4.233 with HTTP; Thu, 27 Jun 2013 14:47:23 -0700 (PDT)
In-Reply-To: <51CBF60C.9080706@b1-systems.de>
References: <51CBF60C.9080706@b1-systems.de>
Date: Fri, 28 Jun 2013 06:47:23 +0900
X-Google-Sender-Auth: -y4juih7atv4ji2OTAV8gxjcPmk
Message-ID: <CAGa2bXZbvgA1iA9QfFoDF+VTUOOa2NuVWoxehUteLERMJyv3xg@mail.gmail.com>
To: Ralf Lang <lang@b1-systems.de>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c28b94815c4f04e029b703
Subject: Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c28b94815c4f04e029b703
Content-Type: text/plain; charset=ISO-8859-1

Hi

Just a comment for the patch.

2013/6/27 Ralf Lang <lang@b1-systems.de>

> Does anybody know of intricate reasons why the existing patch
>
>
> https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest
>
> could not be included into php 5.5?
>

It uses long instead of uint but it makes large files available only to
64bit platforms.

It should use off_t along with "#define _FILE_OFFSET_BITS 64", but I'm not
sure if this work under windows. There may be other places that data type
should be changed. It should be checked carefully, otherwise memory fault
may occur due to integer overflow.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c28b94815c4f04e029b703--