Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67977
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.171 as permitted sender)
MIME-Version: 1.0
Sender: patrick.allaert@gmail.com
In-Reply-To: <1372349657.2376.4.camel@guybrush>
References: <4ED7146272E04A47B986ED49E771E347BB4DF6F344@Ikarus.ameusgmbh.intern>
	<CAF+90c9minNLuJp8ZxX9PUassQWKY-Djd8dj-4vDLdiy_uSa0g@mail.gmail.com>
	<1372349657.2376.4.camel@guybrush>
Date: Thu, 27 Jun 2013 19:09:46 +0200
Message-ID: <CACwt+Jcz3CdAhBc3-JAyPeQxb-0qxvkYgoKiS5xKVHJjf=OSyw@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Christian Stoller <stoller@leonex.de>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] New syntax for multidimensional array loop with foreach
From: patrickallaert@php.net (Patrick ALLAERT)

2013/6/27 Johannes Schl=C3=BCter <johannes@schlueters.de>:
> On Thu, 2013-06-27 at 16:58 +0200, Nikita Popov wrote:
>> On Thu, Jun 27, 2013 at 4:10 PM, Christian Stoller <stoller@leonex.de>wr=
ote:
>>
>> > The new syntax could make it shorter and faster to write... but maybe =
it's
>> > a bit too confusing?
>> >
>> > $count =3D 0;
>> > foreach ($array as $key =3D> $innerArray as $innerKey =3D> $value) {
>> >     $count +=3D $value;
>> >     // and do something with $key and $innerKey
>> > }
>> >
>>
>> I'm against this feature. It makes the code marginally shorter, but a go=
od
>> bit less readable. Combined with the break/continue issue, I don't think=
 we
>> gain anything by introducing this syntax.
>
> +1
>
> Let me add to this:
>
> While the pattern pattern exists often there are things to be done in
> the outer iteration, too. So I think the pure form ofthis double-foreach
> is not as common as it might seem ...
>
> And you can write
>    foreach ($array as $i) foreach ($i as $innerKey =3D> $value) {
>    }
> it is not that much longer, but way more explicit on what is going on,
> visually parsing the suggested form needs more concentration.
>
> johannes

+1 to what Nikita and Johannes said.