Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67976
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 2898 invoked from network); 27 Jun 2013 17:00:45 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 27 Jun 2013 17:00:45 -0000
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.211.66 config.schlueters.de  
Received: from [217.114.211.66] ([217.114.211.66:48953] helo=config.schlueters.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 49/6E-34034-CBF6CC15 for <internals@lists.php.net>; Thu, 27 Jun 2013 13:00:44 -0400
Received: from [192.168.2.20] (ppp-188-174-38-218.dynamic.mnet-online.de [188.174.38.218])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client did not present a certificate)
	by config.schlueters.de (Postfix) with ESMTPSA id 0E93165699;
	Thu, 27 Jun 2013 19:00:41 +0200 (CEST)
To: Christopher Jones <christopher.jones@oracle.com>
Cc: Ralf Lang <lang@b1-systems.de>, "internals@lists.php.net"
 <internals@lists.php.net>
In-Reply-To: <51CC6DCB.7000908@oracle.com>
References: <51CBF60C.9080706@b1-systems.de>
	 <1372350613.2376.12.camel@guybrush> <51CC695B.9060401@b1-systems.de>
	 <51CC6DCB.7000908@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 27 Jun 2013 19:00:40 +0200
Message-ID: <1372352440.2376.41.camel@guybrush>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Thu, 2013-06-27 at 09:52 -0700, Christopher Jones wrote:
> 
> Did you review all the previous mail list discussion about the patch?
> IIRC there were a bunch of reasons it never got merged. 

what we never merged for reasons is large file support. So 32bit
machines can use files >2G. The patches there open a can of worm with
libraries/environments we link to and where we might exchange file
pointers.

Besides the binary compatibility and required review and testing there
is no such reason here. The biggest issue here is that people might be
careful about changing request handling as that's quite central to PHP
and a bug there can lead to remote exploitable bugs, but doing this
early, like now for 5.6, should be fine.

joahnnes