Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67973 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98030 invoked from network); 27 Jun 2013 16:52:37 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2013 16:52:37 -0000 Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain oracle.com designates 156.151.31.81 as permitted sender) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 156.151.31.81 userp1040.oracle.com Received: from [156.151.31.81] ([156.151.31.81:21104] helo=userp1040.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0F/5D-34034-4DD6CC15 for ; Thu, 27 Jun 2013 12:52:36 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5RGkBuX011052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Jun 2013 16:46:12 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5RGqSCG023499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Jun 2013 16:52:29 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5RGqSWJ011822; Thu, 27 Jun 2013 16:52:28 GMT Received: from [130.35.70.82] (/130.35.70.82) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 27 Jun 2013 09:52:28 -0700 Message-ID: <51CC6DCB.7000908@oracle.com> Date: Thu, 27 Jun 2013 09:52:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Ralf Lang CC: =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= , "internals@lists.php.net" References: <51CBF60C.9080706@b1-systems.de> <1372350613.2376.12.camel@guybrush> <51CC695B.9060401@b1-systems.de> In-Reply-To: <51CC695B.9060401@b1-systems.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Subject: Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G From: christopher.jones@oracle.com (Christopher Jones) On 06/27/2013 09:33 AM, Ralf Lang wrote: > Anyway, I have built a version of the patch (using unsigned long instead > of signed long as the original did) against old php 5.3.8 and currently > a test is running with a 4.7 GiB DVD Image. If it works well, I will > submit the patch and attach it to the bug record. > > Thank you for your response. > To make it more reviewable, can you base the patch on the master branch (aka PHP 5.6)? If you're a github user, a PR would be great. Some supporting documentation about what the patch changes, what platforms it was tested on etc would be helpful. I think a brief RFC would be the best place to record the details: https://wiki.php.net/rfc/howto Did you review all the previous mail list discussion about the patch? IIRC there were a bunch of reasons it never got merged. Chris -- christopher.jones@oracle.com http://twitter.com/ghrd Free PHP & Oracle book: http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html