Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67968
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 89795 invoked from network); 27 Jun 2013 16:30:19 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 27 Jun 2013 16:30:19 -0000
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.211.66 config.schlueters.de  
Received: from [217.114.211.66] ([217.114.211.66:58577] helo=config.schlueters.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id AE/9B-34034-8986CC15 for <internals@lists.php.net>; Thu, 27 Jun 2013 12:30:17 -0400
Received: from [192.168.2.20] (ppp-188-174-38-218.dynamic.mnet-online.de [188.174.38.218])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client did not present a certificate)
	by config.schlueters.de (Postfix) with ESMTPSA id 753F26567C;
	Thu, 27 Jun 2013 18:30:13 +0200 (CEST)
To: Ralf Lang <lang@b1-systems.de>
Cc: "internals@lists.php.net" <internals@lists.php.net>
In-Reply-To: <51CBF60C.9080706@b1-systems.de>
References: <51CBF60C.9080706@b1-systems.de>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 27 Jun 2013 18:30:13 +0200
Message-ID: <1372350613.2376.12.camel@guybrush>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

On Thu, 2013-06-27 at 10:21 +0200, Ralf Lang wrote:
> Hi,
> 
> I want to deal with Bug 44522 which disallows uploads > 2G
> https://bugs.php.net/bug.php?id=44522&edit=1

Great!

> Today with PHP cloud solutions, we are running into more situations
> where this really hurts.

Yay cloud :-D
(i don't see why cloud matters, here though it's more about modern
bandwidth and storage space)

> Before I begin providing a github patch (as I have no php svn access and
> I don't think it's needed) against master and possibly 5.5.next:
> 
> Does anybody know of intricate reasons why the existing patch
> 
> https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest
> 
> could not be included into php 5.5?

Most likely since nobody cared enough and pushed it. (both, pushed in
the tree and pushed as in making people aware)

Unfortunately the patch can't make it in 5.5. It changes the size and
offsets in the sapi globals which breaks binary compatibility which we
can't do in a dot release. Has to be 5.6/PHP.next.

I haven't looked close enough to comment on the patch itself.

johannes