Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67966
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Christian Stoller <stoller@leonex.de>, "internals@lists.php.net"
 <internals@lists.php.net>
In-Reply-To: <CAF+90c9minNLuJp8ZxX9PUassQWKY-Djd8dj-4vDLdiy_uSa0g@mail.gmail.com>
References:
	 <4ED7146272E04A47B986ED49E771E347BB4DF6F344@Ikarus.ameusgmbh.intern>
	 <CAF+90c9minNLuJp8ZxX9PUassQWKY-Djd8dj-4vDLdiy_uSa0g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 27 Jun 2013 18:14:17 +0200
Message-ID: <1372349657.2376.4.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] New syntax for multidimensional array loop with
 foreach
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Thu, 2013-06-27 at 16:58 +0200, Nikita Popov wrote:
> On Thu, Jun 27, 2013 at 4:10 PM, Christian Stoller <stoller@leonex.de>wrote:
> 
> > The new syntax could make it shorter and faster to write... but maybe it's
> > a bit too confusing?
> >
> > $count = 0;
> > foreach ($array as $key => $innerArray as $innerKey => $value) {
> >     $count += $value;
> >     // and do something with $key and $innerKey
> > }
> >
> 
> I'm against this feature. It makes the code marginally shorter, but a good
> bit less readable. Combined with the break/continue issue, I don't think we
> gain anything by introducing this syntax.

+1

Let me add to this:

While the pattern pattern exists often there are things to be done in
the outer iteration, too. So I think the pure form ofthis double-foreach
is not as common as it might seem ...

And you can write 
   foreach ($array as $i) foreach ($i as $innerKey => $value) {
   }
it is not that much longer, but way more explicit on what is going on,
visually parsing the suggested form needs more concentration.

johannes