Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67935 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19521 invoked from network); 27 Jun 2013 10:52:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2013 10:52:26 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.178 mail-lb0-f178.google.com Received: from [209.85.217.178] ([209.85.217.178:59163] helo=mail-lb0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/12-08517-9691CC15 for ; Thu, 27 Jun 2013 06:52:26 -0400 Received: by mail-lb0-f178.google.com with SMTP id y6so325767lbh.9 for ; Thu, 27 Jun 2013 03:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=Ts8E7DSW18bWh2jO0JZBn62MWeSy72CpEs2/WFIblCQ=; b=WgB0FC8kcYZz4nb8e66n0aFqOaie2Kn8o+TV5hFdW3ZXfDpbsZgmYaSjID59ZKOAuI yTkrtcp6s6g+SdVt0J01nR7bOYs7u5UPIGFpLpeLrxZQHuwgJqyG0Sia3qrTm0oGUreb YXPPaxCACM3iByffJTgBF/NTr5YshkwOzSn6ySYGwMEopx67/auYZW+gu4dWkAByJ25w D5+3VWUu8jzNZOuxwu0fbMmIMF2ql6XC8wTWvug2K+Ky7rJLt6VbOpCzCuG4q9mOShYS vMudpBdyMUxud+bq5HiZwX3C8aOhb9ZyVUob2hqM3owF0eSgdRm8/a1sMppggItJWask AydA== X-Received: by 10.152.28.199 with SMTP id d7mr3907687lah.67.1372330342757; Thu, 27 Jun 2013 03:52:22 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.4.233 with HTTP; Thu, 27 Jun 2013 03:51:42 -0700 (PDT) In-Reply-To: References: <50364644.1060302@lerdorf.com> <5039D249.30707@sugarcrm.com> <503A968A.4070206@sugarcrm.com> Date: Thu, 27 Jun 2013 19:51:42 +0900 X-Google-Sender-Auth: ht_cr_TjTSWSwDNV0skuK2dOVho Message-ID: To: Arpad Ray Cc: Stas Malyshev , Sherif Ramadan , PHP Internals Content-Type: multipart/alternative; boundary=089e0160b432983e3f04e0208e3f Subject: Re: [PHP-DEV] Session Id Collisions From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e0160b432983e3f04e0208e3f Content-Type: text/plain; charset=ISO-8859-1 Hi Arpad, 2013/6/27 Arpad Ray > I see the strict mode check is now implemented in the handlers and not > session.c, presumably to keep ABI, but this means code is duplicated and > the setting only actually works if the handler supports it. It's > unfortunate timing since 5.5 has just gone, but I think it would make much > more sense to have a new function in the structure (as in your original > patch) and do this only in PHP.next. > > Having such an ini setting which quietly fails if using an unsupported > handler is not good. I guess you could keep a whitelist of supported > handlers but that's also obviously far from ideal. > Thank you for comment. There are plenty of time before 5.6 release, I would like to fix ps_module API also. Current implementation requires ps_modules to access PS(id) to prevent rare case of crash. I'll try to implement a little better API for ps_modules. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --089e0160b432983e3f04e0208e3f--