Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67916
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYBR-=rrifyhWSwB7M1u5J5EL_0o0DcUuFZ9DEuMCrjjQ@mail.gmail.com>
References: <CAGa2bXYNgjhUWTqzhorcYhd7SEyEvxdhCVWyXr8O-hsZ103E6g@mail.gmail.com>
	<CAGa2bXYBR-=rrifyhWSwB7M1u5J5EL_0o0DcUuFZ9DEuMCrjjQ@mail.gmail.com>
Date: Wed, 26 Jun 2013 21:33:44 -0400
Message-ID: <CAL+t6cGUJmfhVdSCf3XNn4Mri_fvq-Fuad40yrrKOd8c1uwxXw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d044481c7c889fd04e018c05d
Subject: Re: [PHP-DEV] Re: hex2bin: E_WARNING is too much for odd string?
From: theanomaly.is@gmail.com (Sherif Ramadan)

--f46d044481c7c889fd04e018c05d
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Jun 26, 2013 at 9:05 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> I've sent pull request for PHP-5.5 branch.
> https://github.com/php/php-src/pull/369
>
> It's simple 1 liner removes E_WARNING for invalid length.
>
> Are there any objections?
>

Yes, I object to removing the error in the same breath we're arguing for
consistency. 5.4.0 through 5.4.3 (no error), 5.4.4 through 5.4.16 (error),
5.5.0 (error), 5.5.1 (no error)??? What kind of consistency is this?

I thought you wanted to add an extra error for malformed hex, which I would
have been fine with, but removing the error entirely? The error is useful.
It informs the user that they may have buggy code since the function is
clearly documented to expect even length hex encoded strings.


> If not I'll merge it to PHP-5.5 and master, then update docs.
>
>
>

--f46d044481c7c889fd04e018c05d--