Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:67913 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67021 invoked from network); 27 Jun 2013 00:37:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Jun 2013 00:37:10 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.43 mail-la0-f43.google.com Received: from [209.85.215.43] ([209.85.215.43:40817] helo=mail-la0-f43.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F0/13-51393-4398BC15 for ; Wed, 26 Jun 2013 20:37:09 -0400 Received: by mail-la0-f43.google.com with SMTP id gw10so119429lab.30 for ; Wed, 26 Jun 2013 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=pF+TJBl+qpgputHJzcUPLtJ+V8QNFa/xoxQlbWvPQtA=; b=o8jYSnTAS9FDkkkqMWORK5CYeBj4U6xbUBBLmN/5aYrNFOzB0gtSNAFcE4ZG80VZ4q gXvBqy5axqL0BgwXRhs/s7u9BBZH1seidPJ/ZhHKg4EwaIHk8wrCEmUsDbyLxdKpcjbA QUF3ouzACzfGVBtZN0ZoEwxSlP1p7FlJuRhLgjE+ZV5H3of5pqYof17fIRDX4JkCRQQR X9+aZkRTmhORMCTlPFcuEOoXtXAo2C6BZTYU2jAM2/WeD1PKbApAAI+C/QV3EdaQRgve uAlD2ptzZZn8i6eiYEVnL99/E8MO2HqanGVymKh6vZTRAF6FwBE/v1rzIwvHG/zkSamJ IoJg== X-Received: by 10.152.23.168 with SMTP id n8mr2940233laf.88.1372293425498; Wed, 26 Jun 2013 17:37:05 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.4.233 with HTTP; Wed, 26 Jun 2013 17:36:24 -0700 (PDT) In-Reply-To: References: <50364644.1060302@lerdorf.com> <5039D249.30707@sugarcrm.com> <503A968A.4070206@sugarcrm.com> Date: Thu, 27 Jun 2013 09:36:24 +0900 X-Google-Sender-Auth: P0bRv_hxacBjD8nhw8TO96kYVk0 Message-ID: To: Stas Malyshev Cc: Sherif Ramadan , PHP Internals Content-Type: multipart/alternative; boundary=089e0160a5d0278f7204e017f65d Subject: Re: [PHP-DEV] Session Id Collisions From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e0160a5d0278f7204e017f65d Content-Type: text/plain; charset=ISO-8859-1 Hi, Sorry for the long delay, I've sent pull requests https://github.com/php/php-src/pull/368 https://github.com/php/php-src/pull/367 https://github.com/php/php-src/pull/366 Thank you for your time. -- Yasuo Ohgaki yohgaki@ohgaki.net 2012/12/24 Yasuo Ohgaki > Hi stats and others, > > Sorry for the delay. > I've finally updated the strict session patch. > > Following diff is against PHP-5.3, but 5.4 and others will be mostly the > same. > > > https://github.com/yohgaki/php-src/commit/42dcd8ef7cd2f9f2071b16586822dadd647c96ef > > I was promised to create separate patch for session id collision > detection, but > the patch is also in the diff. I left comments for the "if" statement > handles > collision. If you still prefer to have separate patch, I'll do it when > I send pull requests. > > If nobody has comment, I'll create patch for 5.4. > > If you read this patch closely, you'll see that this patch accesses > PS(id) global directly due to limitation of current API. It would be > good to have new API for 5.5, I think. > > BTW, this patch fixes bug #60634 as a side effect also. > https://bugs.php.net/bug.php?id=60634 > > Comments are appreciated. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > --089e0160a5d0278f7204e017f65d--