Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67882
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain zend.com from 209.85.219.52 cause and error)
MIME-Version: 1.0
In-Reply-To: <CA+5g0S+L96cKfe_xjua+D+EEunrTBsZjWTnqHvKmw2RauX=vLw@mail.gmail.com>
References: <CAPJnDK3DWSvOJ3wXHk6Q=xTc=FFn2UkpUuPpi4G_2eOeQDjUiA@mail.gmail.com>
	<CA+5g0S+L96cKfe_xjua+D+EEunrTBsZjWTnqHvKmw2RauX=vLw@mail.gmail.com>
Date: Wed, 26 Jun 2013 18:23:35 +0300
Message-ID: <CAPJnDK28PFjTVPOuc=FAsLasoqm=VrS2g6-jJWaWhGTcX4=zUQ@mail.gmail.com>
To: Felipe Pena <felipensp@gmail.com>
Cc: PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0117634fb5009704e0103a92
Subject: Re: [PHP-DEV] Who's incharge of github pull requests?
From: lior.k@zend.com (Lior Kaplan)

--089e0117634fb5009704e0103a92
Content-Type: text/plain; charset=UTF-8

Hi Felipe,

Indeed I saw more responsiveness for the pull requests (mine and others),
thanks.

The question was about the process of reviewing these requests.
1. Do we have someone in charge (making sure they pass some minimum
requirements) or this is done sporadically ?
2. If we do it sporadically, how do we make sure things aren't lost or get
stuck (causing us to lose good patches).

Yes, most of us are volunteers (both the developers and the patch senders)
and this reflects on time issues. With that said, both sides have interest
of seeing more patches sent and accepted.

As I have experience with this on other projects, I'm trying to help
improve the status here. Of course, I'm willing to personally help here, so
I'm not just asking you guys to handle this yourselves.

Kaplan

On Wed, Jun 26, 2013 at 5:28 PM, Felipe Pena <felipensp@gmail.com> wrote:

> Hi,
>
> I saw some patches from you (mentioned in the blog post) has been pushed
> to git.
>
> About the FTP patch, as it requires further testing and an environment
> for such, and we do not have an active maintainer currently for the
> extension. It tend to have a delay until anyone with free time (most
> of we are volunteers), and cares about testing the patch for such
> extension, to get it applied.
>
> Thanks for contributing!
>
>
> 2013/6/16 Lior Kaplan <lior.k@zend.com>:
> > Hi,
> >
> > It seems the list of pull requests on github is getting bigger, who's
> > inchange to review it?
> > https://github.com/php/php-src/pulls
> >
> > I must say that my experience so far in trying to push patches through
> the
> > bug system
> > or pull request is quite deprsing (comparing to other open source
> projects):
> > https://liorkaplan.wordpress.com/2013/06/05/getting-patches-into-php/
> >
> > Kaplan
>
>
>
> --
> Regards,
> Felipe Pena
>

--089e0117634fb5009704e0103a92--