Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:67846
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4ED7146272E04A47B986ED49E771E347BB4DF6F291@Ikarus.ameusgmbh.intern>
References: <etPan.51c8ce38.54e49eb4.5757@MacBook-Air-van-Joost-Koehoorn.local>
 <4ED7146272E04A47B986ED49E771E347BB4DF6F235@Ikarus.ameusgmbh.intern>
 <etPan.51c97c9a.2ca88611.5757@MacBook-Air-van-Joost-Koehoorn.local>
 <51C9DED2.5080401@sugarcrm.com> <CALJZF3gFo4UMzYOhO1Qx4GjtAdEQh_wTE26axW8RZsjaoyUc2g@mail.gmail.com>
 <51C9F485.6050709@sugarcrm.com> <4ED7146272E04A47B986ED49E771E347BB4DF6F291@Ikarus.ameusgmbh.intern>
Date: Wed, 26 Jun 2013 10:00:57 +0200
Message-ID: <CAA9esyRwv7BfFseYXW23SRO5HCEoUazPy4jUt-iLGDaZYT49Yg@mail.gmail.com>
To: Christian Stoller <stoller@leonex.de>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RE: Announcing RFC 'Anonymous Catches'
From: florinpatan@gmail.com (Florin Patan)

On Wed, Jun 26, 2013 at 8:31 AM, Christian Stoller <stoller@leonex.de> wrot=
e:
>>> But I think it looks a bit cleaner if the variable could be omitted,
>>> if it's not needed ;-)
>>
>> I don't think we need to change the language because Netbeans can't
>> figure out how catch blocks work.
>
> The Netbeans thing was just an example/addition.
>
>> It's not used by you - which btw is usually not a good idea - if you've
>> got an exception, you usually should somehow react to it - at least log
>> it or something, that's what the exceptions are for, if the situation
>> does not require special handling it shouldn't be an exception. But it
>
> If you have an exception like `BadCredentialsException` and throw it duri=
ng authentication if the user has entered wrong login data, than you have s=
uch a situation right?
> But do you need any further information? No - in the catch block it may b=
e enough to create a message for the user saying: "wrong username or passwo=
rd".
>
> Maybe you only use generic exceptions like `RuntimeException`. This can b=
e an exception for almost everything. But if you have defined an exception =
for one special case, to interrupt your code, and catch such an exception y=
ou will always know why this exception has been thrown.
> --
> Christian Stoller
> LEONEX Internet GmbH


Hi,


I believe that the example you provided, the one with
'BadCredentialsException', is a good example of a bad design and usage
of exceptions, at least from my point of view.

The fact that frameworks like Symfony2, Zend Framework or other php
libraries/frameworks (ab)use the exceptions it doesn't mean that it's
a good thing or you should have exceptions for everything.

The provided example could just as well return false; for the login
function and that's it, no? Exceptions should be used for exceptional
cases where the application can't recover automatically from them.
They are, even as their name suggests, exceptional cases, while a bad
credential for a user login is not :)

I also believe, and I might not be the only one with this, that
exceptions used for flow control is a good sign of bad design.

If you follow this way of thinking, everytime you throw an exception,
you would want to catch it and perform some work with it, like logging
it for example. So why would you make the variable optional then?



Best regards
----
Florin Patan
https://github.com/dlsniper
http://www.linkedin.com/in/florinpatan